Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1273)

Unified Diff: net/dns/mapped_host_resolver.h

Issue 2116983002: Change HostResolver::Resolve() to take an std::unique_ptr<Request>* rather than a RequestHandle* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: http_stream_factory_impl_job_controller_unittest RequestHandle* to unique_ptr Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/dns/mapped_host_resolver.h
diff --git a/net/dns/mapped_host_resolver.h b/net/dns/mapped_host_resolver.h
index 20c249f7b096047bc8337daffb930b79064415af..30ddc52e969f5cc350ee2dd5b758e833db805490 100644
--- a/net/dns/mapped_host_resolver.h
+++ b/net/dns/mapped_host_resolver.h
@@ -49,12 +49,11 @@ class NET_EXPORT MappedHostResolver : public HostResolver {
RequestPriority priority,
AddressList* addresses,
const CompletionCallback& callback,
- RequestHandle* out_req,
+ std::unique_ptr<Request>* request,
const BoundNetLog& net_log) override;
int ResolveFromCache(const RequestInfo& info,
AddressList* addresses,
const BoundNetLog& net_log) override;
- void CancelRequest(RequestHandle req) override;
void SetDnsClientEnabled(bool enabled) override;
HostCache* GetHostCache() override;
std::unique_ptr<base::Value> GetDnsConfigAsValue() const override;

Powered by Google App Engine
This is Rietveld 408576698