Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: net/dns/host_resolver_mojo.h

Issue 2116983002: Change HostResolver::Resolve() to take an std::unique_ptr<Request>* rather than a RequestHandle* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: http_stream_factory_impl_job_controller_unittest RequestHandle* to unique_ptr Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/dns/host_resolver_mojo.h
diff --git a/net/dns/host_resolver_mojo.h b/net/dns/host_resolver_mojo.h
index 08519d2fc420bc10ad4df7c2680ee2c12456217b..35732bc21f9558749c0ac74114c2e12f042cc162 100644
--- a/net/dns/host_resolver_mojo.h
+++ b/net/dns/host_resolver_mojo.h
@@ -37,18 +37,16 @@ class HostResolverMojo : public HostResolver {
RequestPriority priority,
AddressList* addresses,
const CompletionCallback& callback,
- RequestHandle* request_handle,
+ std::unique_ptr<Request>* request,
const BoundNetLog& source_net_log) override;
int ResolveFromCache(const RequestInfo& info,
AddressList* addresses,
const BoundNetLog& source_net_log) override;
- void ChangeRequestPriority(RequestHandle req,
- RequestPriority priority) override;
- void CancelRequest(RequestHandle req) override;
HostCache* GetHostCache() override;
private:
class Job;
+ class RequestImpl;
int ResolveFromCacheInternal(const RequestInfo& info,
const HostCache::Key& key,

Powered by Google App Engine
This is Rietveld 408576698