net/dns/host_resolver_impl.h - Issue 2116983002: Change HostResolver::Resolve() to take an std::unique_ptr<Request>* rather than a RequestHandle*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/dns/host_resolver_impl.h

Issue 2116983002: Change HostResolver::Resolve() to take an std::unique_ptr<Request>* rather than a RequestHandle* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: http_stream_factory_impl_job_controller_unittest RequestHandle* to unique_ptr Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/dns/host_resolver_impl.h

diff --git a/net/dns/host_resolver_impl.h b/net/dns/host_resolver_impl.h

index 9ab01ca03ea1a6d3ea4a828249d546537a127f4f..68afccc6bf59f00f5964022ae41d93f8b4099ff8 100644

--- a/net/dns/host_resolver_impl.h

+++ b/net/dns/host_resolver_impl.h

@@ -136,11 +136,8 @@ class NET_EXPORT HostResolverImpl

RequestPriority priority,

AddressList* addresses,

const CompletionCallback& callback,

- RequestHandle* out_req,

+ std::unique_ptr<Request>* out_req,

const BoundNetLog& source_net_log) override;

- void ChangeRequestPriority(RequestHandle req,

- RequestPriority priority) override;

- void CancelRequest(RequestHandle req) override;

int ResolveFromCache(const RequestInfo& info,

AddressList* addresses,

const BoundNetLog& source_net_log) override;

@@ -176,7 +173,7 @@ class NET_EXPORT HostResolverImpl

class ProcTask;

class LoopbackProbeJob;

class DnsTask;

- class Request;

+ class RequestImpl;

typedef HostCache::Key Key;

typedef std::map<Key, Job*> JobMap;

« no previous file with comments | « net/dns/host_resolver.cc ('k') | net/dns/host_resolver_impl.cc » ('j') | net/proxy/proxy_resolver_v8_tracing.cc » ('J')