chrome/browser/devtools/device/tcp_device_provider.cc - Issue 2116983002: Change HostResolver::Resolve() to take an std::unique_ptr<Request>* rather than a RequestHandle*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/device/tcp_device_provider.cc

Issue 2116983002: Change HostResolver::Resolve() to take an std::unique_ptr<Request>* rather than a RequestHandle* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: http_stream_factory_impl_job_controller_unittest RequestHandle* to unique_ptr Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/device/port_forwarding_controller.cc ('k') | chromeos/network/host_resolver_impl_chromeos.h » ('j') | net/proxy/proxy_resolver_v8_tracing.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/device/tcp_device_provider.cc

diff --git a/chrome/browser/devtools/device/tcp_device_provider.cc b/chrome/browser/devtools/device/tcp_device_provider.cc

index 33eb767cf52b66f10cb2839fb0c21d3cc60893bd..42ab000a6864212de0f8ed2286fb3bd2e35e9116 100644

--- a/chrome/browser/devtools/device/tcp_device_provider.cc

+++ b/chrome/browser/devtools/device/tcp_device_provider.cc

@@ -40,7 +40,7 @@ class ResolveHostAndOpenSocket final {

request_info, net::DEFAULT_PRIORITY, &address_list_,

base::Bind(&ResolveHostAndOpenSocket::OnResolved,

base::Unretained(this)),

- nullptr, net::BoundNetLog());

+ &request_, net::BoundNetLog());

if (result != net::ERR_IO_PENDING)

OnResolved(result);

}

@@ -60,6 +60,7 @@ class ResolveHostAndOpenSocket final {

}

std::unique_ptr<net::HostResolver> host_resolver_;

+ std::unique_ptr<net::HostResolver::Request> request_;

net::AddressList address_list_;

AdbClientSocket::SocketCallback callback_;

};