net/spdy/spdy_session_unittest.cc - Issue 2116983002: Change HostResolver::Resolve() to take an std::unique_ptr<Request>* rather than a RequestHandle*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_session_unittest.cc

Issue 2116983002: Change HostResolver::Resolve() to take an std::unique_ptr<Request>* rather than a RequestHandle* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mmenke's comments and rebasing Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/api/socket/socket_api.cc ('K') | « net/spdy/spdy_session_pool_unittest.cc ('k') | net/test/spawned_test_server/base_test_server.cc » ('j') | net/tools/gdig/gdig.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/spdy/spdy_session_unittest.cc

diff --git a/net/spdy/spdy_session_unittest.cc b/net/spdy/spdy_session_unittest.cc

index 99d99a79f6fd61c65e70b9d5205e9b44996f12bb..f3dacede2f45f7ac5f393632107bb17ff0357064 100644

--- a/net/spdy/spdy_session_unittest.cc

+++ b/net/spdy/spdy_session_unittest.cc

@@ -3057,10 +3057,11 @@ TEST_P(SpdySessionTest, CloseOneIdleConnectionWithAlias) {

PRIVACY_MODE_DISABLED);

HostResolver::RequestInfo info(key2.host_port_pair());

AddressList addresses;

+ std::unique_ptr<HostResolver::Request> request;

// Pre-populate the DNS cache, since a synchronous resolution is required in

// order to create the alias.

session_deps_.host_resolver->Resolve(info, DEFAULT_PRIORITY, &addresses,

- CompletionCallback(), nullptr,

+ CompletionCallback(), &request,

BoundNetLog());

// Get a session for |key2|, which should return the session created earlier.

base::WeakPtr<SpdySession> session2 =

« extensions/browser/api/socket/socket_api.cc ('K') | « net/spdy/spdy_session_pool_unittest.cc ('k') | net/test/spawned_test_server/base_test_server.cc » ('j') | net/tools/gdig/gdig.cc » ('J')