chromeos/network/host_resolver_impl_chromeos_unittest.cc - Issue 2116983002: Change HostResolver::Resolve() to take an std::unique_ptr<Request>* rather than a RequestHandle*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/host_resolver_impl_chromeos_unittest.cc

Issue 2116983002: Change HostResolver::Resolve() to take an std::unique_ptr<Request>* rather than a RequestHandle* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mmenke's comments and rebasing Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/devtools/device/tcp_device_provider.cc ('K') | « chromeos/network/host_resolver_impl_chromeos.cc ('k') | extensions/browser/api/dns/dns_api.h » ('j') | extensions/browser/api/dns/dns_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromeos/network/host_resolver_impl_chromeos_unittest.cc

diff --git a/chromeos/network/host_resolver_impl_chromeos_unittest.cc b/chromeos/network/host_resolver_impl_chromeos_unittest.cc

index 897376b3ec0ca926da145455e82b3b10fd201366..60a49db1aa2913eaa858a71b4a4de96b50b1e116 100644

--- a/chromeos/network/host_resolver_impl_chromeos_unittest.cc

+++ b/chromeos/network/host_resolver_impl_chromeos_unittest.cc

@@ -100,14 +100,11 @@ class HostResolverImplChromeOSTest : public testing::Test {

}

// Run from IO message loop.

+ std::unique_ptr<net::HostResolver::Request> request_;

mmenke 2016/07/21 16:00:40 This should be moved below all methods in this cla

maksims (do not use this acc) 2016/07/22 10:16:00 Done.

void Resolve(net::HostResolver::RequestInfo info) {

- result_ = host_resolver_->Resolve(

- info,

- net::DEFAULT_PRIORITY,

- &addresses_,

- base::Bind(&ResolveCompletionCallback),

- NULL,

- net_log_);

+ result_ = host_resolver_->Resolve(info, net::DEFAULT_PRIORITY, &addresses_,

+ base::Bind(&ResolveCompletionCallback),

+ &request_, net_log_);

}

void SetDefaultIPConfigs(const std::string& default_device_path) {