Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: net/socket/transport_client_socket_unittest.cc

Issue 2116983002: Change HostResolver::Resolve() to take an std::unique_ptr<Request>* rather than a RequestHandle* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: changed implementation of attach/detach of request Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/transport_client_socket_unittest.cc
diff --git a/net/socket/transport_client_socket_unittest.cc b/net/socket/transport_client_socket_unittest.cc
index 858434d75d8d058770d10fc4d8a0f489cb3a32ac..2b16cd48860843f10820b6a7b43ccc338c2b54a6 100644
--- a/net/socket/transport_client_socket_unittest.cc
+++ b/net/socket/transport_client_socket_unittest.cc
@@ -96,6 +96,7 @@ class TransportClientSocketTest
private:
std::unique_ptr<TCPServerSocket> listen_sock_;
bool close_server_socket_on_next_send_;
+ std::unique_ptr<HostResolver::Request> request_;
mmenke 2016/07/19 19:03:57 This can just be a local in SetUp.
};
void TransportClientSocketTest::SetUp() {
@@ -118,7 +119,7 @@ void TransportClientSocketTest::SetUp() {
HostResolver::RequestInfo info(HostPortPair("localhost", listen_port_));
TestCompletionCallback callback;
int rv = resolver->Resolve(info, DEFAULT_PRIORITY, &addr, callback.callback(),
- NULL, BoundNetLog());
+ &request_, BoundNetLog());
CHECK_EQ(ERR_IO_PENDING, rv);
rv = callback.WaitForResult();
CHECK_EQ(rv, OK);
« net/socket/socks_client_socket_unittest.cc ('K') | « net/socket/ssl_client_socket_pool_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698