net/proxy/proxy_service_mojo_unittest.cc - Issue 2116983002: Change HostResolver::Resolve() to take an std::unique_ptr<Request>* rather than a RequestHandle*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/proxy_service_mojo_unittest.cc

Issue 2116983002: Change HostResolver::Resolve() to take an std::unique_ptr<Request>* rather than a RequestHandle* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: changed implementation of attach/detach of request Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/proxy/proxy_resolver_v8_tracing_wrapper_unittest.cc ('K') | « net/proxy/proxy_resolver_v8_tracing_wrapper_unittest.cc ('k') | net/socket/socks5_client_socket_unittest.cc » ('j') | net/socket/socks5_client_socket_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/proxy/proxy_service_mojo_unittest.cc

diff --git a/net/proxy/proxy_service_mojo_unittest.cc b/net/proxy/proxy_service_mojo_unittest.cc

index afa30076cc9e0aa1ed43c59db38e6708eac0ccf6..451818b895e71dd83525fa41f4cf0fbc8d59cef3 100644

--- a/net/proxy/proxy_service_mojo_unittest.cc

+++ b/net/proxy/proxy_service_mojo_unittest.cc

@@ -114,7 +114,7 @@ class LoggingMockHostResolver : public MockHostResolver {

RequestPriority priority,

AddressList* addresses,

const CompletionCallback& callback,

- RequestHandle* out_req,

+ std::unique_ptr<Request>* out_req,

const BoundNetLog& net_log) override {

net_log.AddEvent(NetLog::TYPE_HOST_RESOLVER_IMPL_JOB);

return MockHostResolver::Resolve(info, priority, addresses, callback,