Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Unified Diff: net/http/http_network_transaction_unittest.cc

Issue 2116983002: Change HostResolver::Resolve() to take an std::unique_ptr<Request>* rather than a RequestHandle* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_network_transaction_unittest.cc
diff --git a/net/http/http_network_transaction_unittest.cc b/net/http/http_network_transaction_unittest.cc
index 76bb795e738dc35703ba1b7a9ca7f4947e69a88d..0f37e9a36ccde4db17948f3c3054f6545efbc525 100644
--- a/net/http/http_network_transaction_unittest.cc
+++ b/net/http/http_network_transaction_unittest.cc
@@ -9373,18 +9373,20 @@ void HttpNetworkTransactionTest::BypassHostCacheOnRefreshHelper(
// Warm up the host cache so it has an entry for "www.example.org".
AddressList addrlist;
TestCompletionCallback callback;
+ std::unique_ptr<HostResolver::Request> req1;
int rv = session_deps_.host_resolver->Resolve(
HostResolver::RequestInfo(HostPortPair("www.example.org", 80)),
- DEFAULT_PRIORITY, &addrlist, callback.callback(), NULL, BoundNetLog());
+ DEFAULT_PRIORITY, &addrlist, callback.callback(), &req1, BoundNetLog());
EXPECT_THAT(rv, IsError(ERR_IO_PENDING));
rv = callback.WaitForResult();
EXPECT_THAT(rv, IsOk());
// Verify that it was added to host cache, by doing a subsequent async lookup
// and confirming it completes synchronously.
+ std::unique_ptr<HostResolver::Request> req2;
rv = session_deps_.host_resolver->Resolve(
HostResolver::RequestInfo(HostPortPair("www.example.org", 80)),
- DEFAULT_PRIORITY, &addrlist, callback.callback(), NULL, BoundNetLog());
+ DEFAULT_PRIORITY, &addrlist, callback.callback(), &req2, BoundNetLog());
ASSERT_THAT(rv, IsOk());
// Inject a failure the next time that "www.example.org" is resolved. This way
@@ -12918,11 +12920,9 @@ TEST_P(HttpNetworkTransactionTest, UseIPConnectionPooling) {
HostPortPair host_port("www.gmail.com", 443);
HostResolver::RequestInfo resolve_info(host_port);
AddressList ignored;
- rv = session_deps_.host_resolver->Resolve(resolve_info,
- DEFAULT_PRIORITY,
- &ignored,
- callback.callback(),
- NULL,
+ std::unique_ptr<HostResolver::Request> req;
+ rv = session_deps_.host_resolver->Resolve(resolve_info, DEFAULT_PRIORITY,
+ &ignored, callback.callback(), &req,
BoundNetLog());
EXPECT_THAT(rv, IsError(ERR_IO_PENDING));
rv = callback.WaitForResult();
@@ -13042,7 +13042,7 @@ class OneTimeCachingHostResolver : public HostResolver {
RequestPriority priority,
AddressList* addresses,
const CompletionCallback& callback,
- RequestHandle* out_req,
+ std::unique_ptr<Request>* out_req,
const BoundNetLog& net_log) override {
return host_resolver_.Resolve(
info, priority, addresses, callback, out_req, net_log);
@@ -13057,10 +13057,6 @@ class OneTimeCachingHostResolver : public HostResolver {
return rv;
}
- void CancelRequest(RequestHandle req) override {
- host_resolver_.CancelRequest(req);
- }
-
MockCachingHostResolver* GetMockHostResolver() {
return &host_resolver_;
}
@@ -13138,12 +13134,9 @@ TEST_P(HttpNetworkTransactionTest,
// Preload cache entries into HostCache.
HostResolver::RequestInfo resolve_info(HostPortPair("www.gmail.com", 443));
AddressList ignored;
- rv = host_resolver.Resolve(resolve_info,
- DEFAULT_PRIORITY,
- &ignored,
- callback.callback(),
- NULL,
- BoundNetLog());
+ std::unique_ptr<HostResolver::Request> req;
+ rv = host_resolver.Resolve(resolve_info, DEFAULT_PRIORITY, &ignored,
+ callback.callback(), &req, BoundNetLog());
EXPECT_THAT(rv, IsError(ERR_IO_PENDING));
rv = callback.WaitForResult();
EXPECT_THAT(rv, IsOk());

Powered by Google App Engine
This is Rietveld 408576698