net/dns/mojo_host_resolver_impl.cc - Issue 2116983002: Change HostResolver::Resolve() to take an std::unique_ptr<Request>* rather than a RequestHandle*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/dns/mojo_host_resolver_impl.cc

Issue 2116983002: Change HostResolver::Resolve() to take an std::unique_ptr<Request>* rather than a RequestHandle* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/dns/mojo_host_resolver_impl.cc

diff --git a/net/dns/mojo_host_resolver_impl.cc b/net/dns/mojo_host_resolver_impl.cc

index 13f61d51dd4d60d727e90313e153fc35a890f9be..b244bf88edb151b87395a1a36722b7d90de73f85 100644

--- a/net/dns/mojo_host_resolver_impl.cc

+++ b/net/dns/mojo_host_resolver_impl.cc

@@ -41,7 +41,7 @@ class MojoHostResolverImpl::Job {

net::HostResolver::RequestInfo request_info_;

const BoundNetLog net_log_;

interfaces::HostResolverRequestClientPtr client_;

- net::HostResolver::RequestHandle handle_;

+ std::unique_ptr<net::HostResolver::Request> handle_;

AddressList result_;

base::ThreadChecker thread_checker_;

};

@@ -112,7 +112,7 @@ void MojoHostResolverImpl::Job::Start() {

MojoHostResolverImpl::Job::~Job() {

DCHECK(thread_checker_.CalledOnValidThread());

if (handle_)

- resolver_->CancelRequest(handle_);

+ handle_.reset();

}

void MojoHostResolverImpl::Job::OnResolveDone(int result) {

« net/dns/host_resolver_impl.cc ('K') | « net/dns/mock_host_resolver.cc ('k') | net/dns/mojo_host_resolver_impl_unittest.cc » ('j') | no next file with comments »