Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: net/dns/host_resolver_mojo_unittest.cc

Issue 2116983002: Change HostResolver::Resolve() to take an std::unique_ptr<Request>* rather than a RequestHandle* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/dns/host_resolver_mojo_unittest.cc
diff --git a/net/dns/host_resolver_mojo_unittest.cc b/net/dns/host_resolver_mojo_unittest.cc
index 57bdb5e8de481ac4cb1eae28e489e96b113fcc96..92f08586e51086043d5fc0e61e0db4326a43c787 100644
--- a/net/dns/host_resolver_mojo_unittest.cc
+++ b/net/dns/host_resolver_mojo_unittest.cc
@@ -166,17 +166,18 @@ class HostResolverMojoTest : public testing::Test {
int Resolve(const HostResolver::RequestInfo& request_info,
AddressList* result) {
- HostResolver::RequestHandle request_handle = nullptr;
TestCompletionCallback callback;
- return callback.GetResult(resolver_->Resolve(
- request_info, DEFAULT_PRIORITY, result, callback.callback(),
- &request_handle, BoundNetLog()));
+ return callback.GetResult(resolver_->Resolve(request_info, DEFAULT_PRIORITY,
+ result, callback.callback(),
+ &request_, BoundNetLog()));
}
std::unique_ptr<MockMojoHostResolver> mock_resolver_;
std::unique_ptr<HostResolverMojo> resolver_;
+ std::unique_ptr<HostResolver::Request> request_;
+
Waiter waiter_;
};
@@ -254,18 +255,16 @@ TEST_F(HostResolverMojoTest, Multiple) {
request_info2.set_address_family(ADDRESS_FAMILY_IPV6);
AddressList result1;
AddressList result2;
- HostResolver::RequestHandle request_handle1 = nullptr;
- HostResolver::RequestHandle request_handle2 = nullptr;
+ std::unique_ptr<HostResolver::Request> req1;
+ std::unique_ptr<HostResolver::Request> req2;
TestCompletionCallback callback1;
TestCompletionCallback callback2;
ASSERT_EQ(ERR_IO_PENDING,
resolver_->Resolve(request_info1, DEFAULT_PRIORITY, &result1,
- callback1.callback(), &request_handle1,
- BoundNetLog()));
+ callback1.callback(), &req1, BoundNetLog()));
ASSERT_EQ(ERR_IO_PENDING,
resolver_->Resolve(request_info2, DEFAULT_PRIORITY, &result2,
- callback2.callback(), &request_handle2,
- BoundNetLog()));
+ callback2.callback(), &req2, BoundNetLog()));
EXPECT_THAT(callback1.GetResult(ERR_IO_PENDING), IsOk());
EXPECT_THAT(callback2.GetResult(ERR_IO_PENDING),
IsError(ERR_NAME_NOT_RESOLVED));
@@ -323,10 +322,10 @@ TEST_F(HostResolverMojoTest, Cancel) {
HostPortPair::FromString("example.com:80"));
request_info.set_address_family(ADDRESS_FAMILY_IPV6);
AddressList result;
- HostResolver::RequestHandle request_handle = nullptr;
+ std::unique_ptr<HostResolver::Request> request_handle;
resolver_->Resolve(request_info, DEFAULT_PRIORITY, &result, base::Bind(&Fail),
&request_handle, BoundNetLog());
- resolver_->CancelRequest(request_handle);
+ request_handle.reset();
waiter_.WaitForEvent(ConnectionErrorSource::REQUEST);
EXPECT_TRUE(result.empty());

Powered by Google App Engine
This is Rietveld 408576698