Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: extensions/browser/api/sockets_tcp/sockets_tcp_api.cc

Issue 2116983002: Change HostResolver::Resolve() to take an std::unique_ptr<Request>* rather than a RequestHandle* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« extensions/browser/api/socket/socket_api.cc ('K') | « extensions/browser/api/socket/socket_api.cc ('k') | extensions/browser/api/sockets_udp/sockets_udp_api.cc » ('j') | net/dns/host_resolver.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/sockets_tcp/sockets_tcp_api.cc
diff --git a/extensions/browser/api/sockets_tcp/sockets_tcp_api.cc b/extensions/browser/api/sockets_tcp/sockets_tcp_api.cc
index be8e45d1c08979ee60d8587016989606ff030b9d..47bb97218d5c52bf733e57c5cc168a28d2735892 100644
--- a/extensions/browser/api/sockets_tcp/sockets_tcp_api.cc
+++ b/extensions/browser/api/sockets_tcp/sockets_tcp_api.cc
@@ -289,6 +289,10 @@ void SocketsTcpConnectFunction::AfterDnsLookup(int lookup_result) {
} else {
OnCompleted(lookup_result);
}
+
+ // TODO(maksims): investigate why std::unique_ptr<HostResolver::Request>'s
+ // destructor is not called automatically.
+ request_handle_.reset();
}
void SocketsTcpConnectFunction::StartConnect() {
« extensions/browser/api/socket/socket_api.cc ('K') | « extensions/browser/api/socket/socket_api.cc ('k') | extensions/browser/api/sockets_udp/sockets_udp_api.cc » ('j') | net/dns/host_resolver.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698