Change HostResolver::Resolve() to take an std::unique_ptr<Request>* rather than a RequestHandle*

net/dns/host_resolver.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_DNS_HOST_RESOLVER_H_
 #define NET_DNS_HOST_RESOLVER_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 24 matching lines @@
 // literal) to an AddressList object.
 //
 // HostResolver can handle multiple requests at a time, so when cancelling a
 // request the RequestHandle that was returned by Resolve() needs to be
 // given.  A simpler alternative for consumers that only have 1 outstanding
 // request at a time is to create a SingleRequestHostResolver wrapper around
 // HostResolver (which will automatically cancel the single request when it
 // goes out of scope).
 class NET_EXPORT HostResolver {
  public:
+  class NET_EXPORT Request {

[mmenke, 2016/07/12 18:50:23]

Document this class.

(Owned by the consumer, deletion cancels the request)

[maksims (do not use this acc), 2016/07/19 15:00:26]

Done.

+   public:
+    virtual ~Request() {}
+
+    // Changes the priority of the request. ChangeRequestPriority must NOT be
+    // called after the request's completion callback has already run.
+    virtual void ChangeRequestPriority(RequestPriority priority) = 0;
+  };
+
   // |max_concurrent_resolves| is how many resolve requests will be allowed to
   // run in parallel. Pass HostResolver::kDefaultParallelism to choose a
   // default value.
   // |max_retry_attempts| is the maximum number of times we will retry for host
   // resolution. Pass HostResolver::kDefaultRetryAttempts to choose a default
   // value.
   // |enable_caching| controls whether a HostCache is used.
   struct NET_EXPORT Options {
     Options();
 
@@ skipping 53 matching lines @@
     bool allow_cached_response_;
 
     // Whether this request was started by the DNS prefetcher.
     bool is_speculative_;
 
     // Indicates a request for myIpAddress (to differentiate from other requests
     // for localhost, currently used by Chrome OS).
     bool is_my_ip_address_;
   };
 
-  // Opaque type used to cancel a request.
-  typedef void* RequestHandle;
-
   // Set Options.max_concurrent_resolves to this to select a default level
   // of concurrency.
   static const size_t kDefaultParallelism = 0;
 
   // Set Options.max_retry_attempts to this to select a default retry value.
   static const size_t kDefaultRetryAttempts = static_cast<size_t>(-1);
 
   // If any completion callbacks are pending when the resolver is destroyed,
   // the host resolutions are cancelled, and the completion callbacks will not
   // be called.
   virtual ~HostResolver();
 
   // Resolves the given hostname (or IP address literal), filling out the
   // |addresses| object upon success.  The |info.port| parameter will be set as
   // the sin(6)_port field of the sockaddr_in{6} struct.  Returns OK if
   // successful or an error code upon failure.  Returns
   // ERR_NAME_NOT_RESOLVED if hostname is invalid, or if it is an
   // incompatible IP literal (e.g. IPv6 is disabled and it is an IPv6
   // literal).
   //
   // If the operation cannot be completed synchronously, ERR_IO_PENDING will
   // be returned and the real result code will be passed to the completion
   // callback.  Otherwise the result code is returned immediately from this
   // call.
   //
   // If |out_req| is non-NULL, then |*out_req| will be filled with a handle to

[Devlin, 2016/07/12 15:04:51]

is out_req still allowed to be null?  It doesn't look like it.

   // the async request. This handle is not valid after the request has
   // completed.

[mmenke, 2016/07/12 18:50:23]

This entire paragraph needs to be re-written.

[maksims (do not use this acc), 2016/07/19 15:00:26]

Done.

   //
   // Profiling information for the request is saved to |net_log| if non-NULL.
   virtual int Resolve(const RequestInfo& info,
                       RequestPriority priority,
                       AddressList* addresses,
                       const CompletionCallback& callback,
-                      RequestHandle* out_req,
+                      std::unique_ptr<Request>* out_req,

[Devlin, 2016/07/12 15:04:51]

I'm not familiar with the implementation here at all, so more of a question than
a comment.

It looks like we now link the Job with the request - is there a lifetime
requirement related to the out_req?  e.g., if I pass in a stack-allocated
std::unique_ptr<Request> that's deleted right after the call to this, and the
Job finishes async, will that cause a crash?  We should document any lifetime
requirements here.

[mmenke, 2016/07/12 18:50:23]

No - it should be deleted the cancel the request.  IT was already implicitly
linked to the job before, this just makes cancellation less prone to bugginess.

This should be documented.

[maksims (do not use this acc), 2016/07/19 15:00:25]

Done.

                       const BoundNetLog& net_log) = 0;
 
-  // Changes the priority of the specified request. |req| is the handle returned
-  // by Resolve(). ChangeRequestPriority must NOT be called after the request's
-  // completion callback has already run or the request was canceled.
-  virtual void ChangeRequestPriority(RequestHandle req,
-                                     RequestPriority priority);
-
-  // Cancels the specified request. |req| is the handle returned by Resolve().
-  // After a request is canceled, its completion callback will not be called.
-  // CancelRequest must NOT be called after the request's completion callback
-  // has already run or the request was canceled.
-  virtual void CancelRequest(RequestHandle req) = 0;
-
   // Resolves the given hostname (or IP address literal) out of cache or HOSTS
   // file (if enabled) only. This is guaranteed to complete synchronously.
   // This acts like |Resolve()| if the hostname is IP literal, or cached value
   // or HOSTS entry exists. Otherwise, ERR_DNS_CACHE_MISS is returned.
   virtual int ResolveFromCache(const RequestInfo& info,
                                AddressList* addresses,
                                const BoundNetLog& net_log) = 0;
 
   // Enable or disable the built-in asynchronous DnsClient.
   virtual void SetDnsClientEnabled(bool enabled);
@@ skipping 19 matching lines @@
  protected:
   HostResolver();
 
  private:
   DISALLOW_COPY_AND_ASSIGN(HostResolver);
 };
 
 }  // namespace net
 
 #endif  // NET_DNS_HOST_RESOLVER_H_