build_overrides/v8.gni - Issue 2116913002: Land v8-side changes to switch to v8_current_cpu in the GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build_overrides/v8.gni

Issue 2116913002: Land v8-side changes to switch to v8_current_cpu in the GN build. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: rework to use custom_toolchain, not buildconfig Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build_overrides/v8.gni

diff --git a/build_overrides/v8.gni b/build_overrides/v8.gni

index 5dcd67257a8e40443db653b45cea8e2394efdbe3..76b2d4d3096bc2ae976183d724f0c7973e7e9ff6 100644

--- a/build_overrides/v8.gni

+++ b/build_overrides/v8.gni

@@ -11,11 +11,11 @@ if (is_android) {

import("//build/config/android/config.gni")

}

-if (((v8_target_cpu == "x86" ||

- v8_target_cpu == "x64" ||

- v8_target_cpu=="x87") &&

+if (((v8_current_cpu == "x86" ||

+ v8_current_cpu == "x64" ||

+ v8_current_cpu=="x87") &&

(is_linux || is_mac)) ||

- (v8_target_cpu == "ppc64" && is_linux)) {

+ (v8_current_cpu == "ppc64" && is_linux)) {

v8_enable_gdbjit = true

}

« BUILD.gn ('K') | « BUILD.gn ('k') | gni/v8.gni » ('j') | no next file with comments »