build_overrides/v8.gni - Issue 2116913002: Land v8-side changes to switch to v8_current_cpu in the GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build_overrides/v8.gni

Issue 2116913002: Land v8-side changes to switch to v8_current_cpu in the GN build. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: remove incorrect assert Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build_overrides/v8.gni

diff --git a/build_overrides/v8.gni b/build_overrides/v8.gni

index 7ba4d58384975606ab439462df617497c1cfa0fa..05c542ab2703e4d143248aa43a1a65bf1a9f6a97 100644

--- a/build_overrides/v8.gni

+++ b/build_overrides/v8.gni

@@ -11,12 +11,12 @@ if (is_android) {

import("//build/config/android/config.gni")

}

-if (((v8_target_cpu == "x86" ||

- v8_target_cpu == "x64" ||

- v8_target_cpu=="x87") &&

+if (((v8_current_cpu == "x86" ||

+ v8_current_cpu == "x64" ||

+ v8_current_cpu=="x87") &&

(is_linux || is_mac)) ||

- (v8_target_cpu == "ppc64" && is_linux)) {

- v8_enable_gdbjit_default = true

Michael Achenbach 2016/07/18 14:47:06 v8_enable_gdbjit_default got removed here by rebas

Dirk Pranke 2016/07/18 16:45:11 Argh, I thought I had fixed that, sorry :(.

+ (v8_current_cpu == "ppc64" && is_linux)) {

+ v8_enable_gdbjit = true

}

v8_imminent_deprecation_warnings_default = true

« no previous file with comments | « BUILD.gn ('k') | gni/v8.gni » ('j') | snapshot_toolchain.gni » ('J')