NQE: Record how frequently NetworkID is available

NQE: Record how frequently NetworkID is available

NQE maintains cache of network quality keyed by
NetworkID (tuple consisting of connection type, and
connection name). If the NetworkID is unavailable, then
the catching is not done.

BUG=626106
Committed: https://crrev.com/ad2bf01ba65d5c3c0c1cdf4ca6cbd969c8f48bec
Cr-Commit-Position: refs/heads/master@{#406431}

[tbansal1, 2016-07-01 23:26:01]

Description was changed from

==========
Record how frequently NetworkID is available

BUG=
==========

to

==========
NQE: Record how frequently NetworkID is available

BUG=
==========

[tbansal1, 2016-07-01 23:27:44]

tbansal@chromium.org changed reviewers:
+ kundaji@chromium.org

[tbansal1, 2016-07-01 23:27:45]

kundaji: ptal. This was split off from
https://codereview.chromium.org/2081493002/#ps100001 since the reviewers
suggested to keep the NQE changes separate. Thanks!!

[Not at Google. Contact bengr, 2016-07-06 17:09:43]

lgtm

Remove BUG= line from description

[tbansal1, 2016-07-06 17:14:05]

Description was changed from

==========
NQE: Record how frequently NetworkID is available

BUG=
==========

to

==========
NQE: Record how frequently NetworkID is available
==========

[tbansal1, 2016-07-06 20:26:37]

Description was changed from

==========
NQE: Record how frequently NetworkID is available
==========

to

==========
NQE: Record how frequently NetworkID is available

BUG=626106
==========

[tbansal1, 2016-07-06 20:27:02]

tbansal@chromium.org changed reviewers:
+ bengr@chromium.org

[tbansal1, 2016-07-06 20:27:03]

bengr: ptal. Thanks.

[bengr, 2016-07-08 17:00:07]

Please update the CL description to say what a network ID is, and add a space
between Network and ID in the CL title.

https://codereview.chromium.org/2116893002/diff/1/net/nqe/network_quality_est...
File net/nqe/network_quality_estimator.cc (right):

https://codereview.chromium.org/2116893002/diff/1/net/nqe/network_quality_est...
net/nqe/network_quality_estimator.cc:744: // Update the local state for the new
connection.
I don't understand this comment.

https://codereview.chromium.org/2116893002/diff/1/net/nqe/network_quality_est...
File net/nqe/network_quality_estimator.h (right):

https://codereview.chromium.org/2116893002/diff/1/net/nqe/network_quality_est...
net/nqe/network_quality_estimator.h:408: // Records UMA on whether the network
ID was available or not. Called right
Please describe what a network ID is.

https://codereview.chromium.org/2116893002/diff/1/net/nqe/network_quality_est...
File net/nqe/network_quality_estimator_unittest.cc (right):

https://codereview.chromium.org/2116893002/diff/1/net/nqe/network_quality_est...
net/nqe/network_quality_estimator_unittest.cc:1820: // Network ID is recorded as
available on Wi-Fi connection.
Network -> The network

https://codereview.chromium.org/2116893002/diff/1/net/nqe/network_quality_est...
net/nqe/network_quality_estimator_unittest.cc:1825: // Histogram is not recorded
on unknown connection.
Histogram -> The histogram
on -> on an

https://codereview.chromium.org/2116893002/diff/1/net/nqe/network_quality_est...
net/nqe/network_quality_estimator_unittest.cc:1830: // Network ID is recorded as
not available on Wi-Fi connection with empty
Network -> The network
not -> not being
on -> on a
with -> with an

https://codereview.chromium.org/2116893002/diff/1/net/nqe/network_quality_est...
net/nqe/network_quality_estimator_unittest.cc:1837: // Network ID is recorded as
available on Wi-Fi connection.
Network -> The network
as -> as being
on -> on a

https://codereview.chromium.org/2116893002/diff/1/net/nqe/network_quality_est...
net/nqe/network_quality_estimator_unittest.cc:1843: // Network ID is recorded as
available on cellular connection.
Network -> The network
as -> as being
on -> on a

[tbansal1, 2016-07-08 18:15:01]

Description was changed from

==========
NQE: Record how frequently NetworkID is available

BUG=626106
==========

to

==========
NQE: Record how frequently NetworkID is available

NQE maintains cache of network quality keyed by 
NetworkID (tuple consisting of connection type, and 
connection name). If the NetworkID is unavailable, then
the catching is not done.

BUG=626106
==========

[tbansal1, 2016-07-08 18:39:08]

bengr: ptal. Thanks!

https://codereview.chromium.org/2116893002/diff/1/net/nqe/network_quality_est...
File net/nqe/network_quality_estimator.cc (right):

https://codereview.chromium.org/2116893002/diff/1/net/nqe/network_quality_est...
net/nqe/network_quality_estimator.cc:744: // Update the local state for the new
connection.
On 2016/07/08 17:00:07, bengr wrote:
> I don't understand this comment.

Reworded.
First, the local state is cleared ("// Clear the local state." comment above).
Then, the local state is updated to reflect the new connection.

https://codereview.chromium.org/2116893002/diff/1/net/nqe/network_quality_est...
File net/nqe/network_quality_estimator.h (right):

https://codereview.chromium.org/2116893002/diff/1/net/nqe/network_quality_est...
net/nqe/network_quality_estimator.h:408: // Records UMA on whether the network
ID was available or not. Called right
On 2016/07/08 17:00:07, bengr wrote:
> Please describe what a network ID is.

Changed it to NetworkID which is a defined struct.

https://codereview.chromium.org/2116893002/diff/1/net/nqe/network_quality_est...
File net/nqe/network_quality_estimator_unittest.cc (right):

https://codereview.chromium.org/2116893002/diff/1/net/nqe/network_quality_est...
net/nqe/network_quality_estimator_unittest.cc:1820: // Network ID is recorded as
available on Wi-Fi connection.
On 2016/07/08 17:00:07, bengr wrote:
> Network -> The network

Done.

https://codereview.chromium.org/2116893002/diff/1/net/nqe/network_quality_est...
net/nqe/network_quality_estimator_unittest.cc:1825: // Histogram is not recorded
on unknown connection.
On 2016/07/08 17:00:07, bengr wrote:
> Histogram -> The histogram
> on -> on an

Done.

https://codereview.chromium.org/2116893002/diff/1/net/nqe/network_quality_est...
net/nqe/network_quality_estimator_unittest.cc:1830: // Network ID is recorded as
not available on Wi-Fi connection with empty
On 2016/07/08 17:00:07, bengr wrote:
> Network -> The network
> not -> not being
> on -> on a
> with -> with an

Done.

https://codereview.chromium.org/2116893002/diff/1/net/nqe/network_quality_est...
net/nqe/network_quality_estimator_unittest.cc:1837: // Network ID is recorded as
available on Wi-Fi connection.
On 2016/07/08 17:00:07, bengr wrote:
> Network -> The network
> as -> as being
> on -> on a

Done.

https://codereview.chromium.org/2116893002/diff/1/net/nqe/network_quality_est...
net/nqe/network_quality_estimator_unittest.cc:1843: // Network ID is recorded as
available on cellular connection.
On 2016/07/08 17:00:07, bengr wrote:
> Network -> The network
> as -> as being
> on -> on a

Done.

[bengr, 2016-07-19 00:45:35]

lgtm

[tbansal1, 2016-07-19 00:52:13]

tbansal@chromium.org changed reviewers:
+ rkaplow@chromium.org

[tbansal1, 2016-07-19 00:52:13]

rkaplow: ptal at histograms.xml. Thanks

[rkaplow, 2016-07-19 15:28:12]

lgtm

[tbansal1, 2016-07-19 23:23:22]

The CQ bit was checked by tbansal@chromium.org

[tbansal1, 2016-07-19 23:23:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
kundaji@chromium.org, bengr@chromium.org, rkaplow@chromium.org
Link to the patchset: https://codereview.chromium.org/2116893002/#ps60001
(title: "rebased")

[commit-bot: I haz the power, 2016-07-19 23:24:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 00:53:27]

Description was changed from

==========
NQE: Record how frequently NetworkID is available

NQE maintains cache of network quality keyed by 
NetworkID (tuple consisting of connection type, and 
connection name). If the NetworkID is unavailable, then
the catching is not done.

BUG=626106
==========

to

==========
NQE: Record how frequently NetworkID is available

NQE maintains cache of network quality keyed by 
NetworkID (tuple consisting of connection type, and 
connection name). If the NetworkID is unavailable, then
the catching is not done.

BUG=626106
==========

[commit-bot: I haz the power, 2016-07-20 00:53:28]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-20 00:53:49]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-20 00:55:03]

Description was changed from

==========
NQE: Record how frequently NetworkID is available

NQE maintains cache of network quality keyed by 
NetworkID (tuple consisting of connection type, and 
connection name). If the NetworkID is unavailable, then
the catching is not done.

BUG=626106
==========

to

==========
NQE: Record how frequently NetworkID is available

NQE maintains cache of network quality keyed by
NetworkID (tuple consisting of connection type, and
connection name). If the NetworkID is unavailable, then
the catching is not done.

BUG=626106

Committed: https://crrev.com/ad2bf01ba65d5c3c0c1cdf4ca6cbd969c8f48bec
Cr-Commit-Position: refs/heads/master@{#406431}
==========

[commit-bot: I haz the power, 2016-07-20 00:55:04]

Patchset 4 (id:??) landed as
https://crrev.com/ad2bf01ba65d5c3c0c1cdf4ca6cbd969c8f48bec
Cr-Commit-Position: refs/heads/master@{#406431}