Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 21168006: added drawVertices path to GameBench (Closed)

Created:
7 years, 4 months ago by robertphillips
Modified:
7 years, 4 months ago
Reviewers:
bsalomon, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Seems to be a win for GPU. Not so much for raster. Note that I had hoped for an even greater improvement since we are giving up clamping but we are probably still not getting full batching. game_trans_full_atlas_drawVerts_aa 8888: cmsecs = 95.63 GPU: cmsecs = 13.88 gmsecs = 10.72 game_trans_full_atlas_aa 8888: cmsecs = 20.59 GPU: cmsecs = 17.00 gmsecs = 6.89

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -10 lines) Patch
M bench/GameBench.cpp View 9 chunks +44 lines, -9 lines 0 comments Download
M include/core/SkCanvas.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
robertphillips
7 years, 4 months ago (2013-07-31 14:45:43 UTC) #1
reed1
lgtm
7 years, 4 months ago (2013-07-31 14:56:16 UTC) #2
bsalomon
On 2013/07/31 14:45:43, robertphillips wrote: lgtm
7 years, 4 months ago (2013-07-31 14:56:17 UTC) #3
robertphillips
7 years, 4 months ago (2013-07-31 14:58:06 UTC) #4
Message was sent while issue was closed.
committed as r10459

Powered by Google App Engine
This is Rietveld 408576698