android_webview/tools/system_webview_shell/test/data/blink-apis/webmidi/requestmidiaccess.html - Issue 2116763002: Reland: Web MIDI: use mojom::blink::PermissionService directly to ask permission

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/tools/system_webview_shell/test/data/blink-apis/webmidi/requestmidiaccess.html

Issue 2116763002: Reland: Web MIDI: use mojom::blink::PermissionService directly to ask permission (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: system_webview_shell_layout_test workaround Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/tools/system_webview_shell/layout_tests/src/org/chromium/webview_shell/test/WebViewLayoutTest.java ('K') | « android_webview/tools/system_webview_shell/layout_tests/src/org/chromium/webview_shell/test/WebViewLayoutTest.java ('k') | android_webview/tools/system_webview_shell/test/data/blink-apis/webmidi/requestmidiaccess-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/tools/system_webview_shell/test/data/blink-apis/webmidi/requestmidiaccess.html

diff --git a/android_webview/tools/system_webview_shell/test/data/blink-apis/webmidi/requestmidiaccess.html b/android_webview/tools/system_webview_shell/test/data/blink-apis/webmidi/requestmidiaccess.html

index 58258bed83369f7ea27a10c479dfeff3a2fe2173..220c71dea9e2bcd1fea70bfef8c6fe0d9c2ba3f0 100644

--- a/android_webview/tools/system_webview_shell/test/data/blink-apis/webmidi/requestmidiaccess.html

+++ b/android_webview/tools/system_webview_shell/test/data/blink-apis/webmidi/requestmidiaccess.html

@@ -13,13 +13,13 @@

function onMIDISuccess(access) {

window.access = access;

- shouldBeTrue('access.sysexEnabled');

- testPassed('requestMIDIAccess with option sysex:true succeeded.');

+ shouldBeFalse('access.sysexEnabled');

+ testPassed('requestMIDIAccess without option succeeded.');

finishJSTest();

}

- navigator.requestMIDIAccess({sysex:true}).then(

- onMIDISuccess, onMIDIError);

+ // TODO(toyoshim): Add another version to request with {sysex:true}.

Takashi Toyoshima 2016/07/08 07:26:53 This is a workaround. I will add {sysex:true} case

+ navigator.requestMIDIAccess().then(onMIDISuccess, onMIDIError);

</script>

</body>

-</html>

+</html>