third_party/WebKit/Source/web/WebLocalFrameImpl.cpp - Issue 2116763002: Reland: Web MIDI: use mojom::blink::PermissionService directly to ask permission

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2116763002: Reland: Web MIDI: use mojom::blink::PermissionService directly to ask permission (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review #13 Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.cpp ('K') | « third_party/WebKit/Source/web/MIDIClientProxy.cpp ('k') | third_party/WebKit/Source/web/WebMIDIPermissionRequest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

index c8a165a11f023e7524e4feb07a2fa2513e0b9249..c8e84e14f3885b36a9d73ac9e4f142b322341a39 100644

--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

@@ -221,7 +221,6 @@

#include "web/FindInPageCoordinates.h"

#include "web/IndexedDBClientImpl.h"

#include "web/LocalFileSystemClient.h"

-#include "web/MIDIClientProxy.h"

#include "web/NavigatorContentUtilsClientImpl.h"

#include "web/NotificationPermissionClientImpl.h"

#include "web/RemoteFrameOwner.h"

@@ -1468,7 +1467,6 @@ void WebLocalFrameImpl::setCoreFrame(LocalFrame* frame)

provideNotificationPermissionClientTo(*m_frame, NotificationPermissionClientImpl::create());

provideUserMediaTo(*m_frame, &m_userMediaClientImpl);

- provideMIDITo(*m_frame, MIDIClientProxy::create(m_client ? m_client->webMIDIClient() : nullptr));

provideIndexedDBClientTo(*m_frame, IndexedDBClientImpl::create());

provideLocalFileSystemTo(*m_frame, LocalFileSystemClient::create());

provideNavigatorContentUtilsTo(*m_frame, NavigatorContentUtilsClientImpl::create(this));