content/renderer/render_frame_impl.h - Issue 2116763002: Reland: Web MIDI: use mojom::blink::PermissionService directly to ask permission

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.h

Issue 2116763002: Reland: Web MIDI: use mojom::blink::PermissionService directly to ask permission (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review #13 Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/midi_dispatcher.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_frame_impl.h

diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h

index 2ff0dd716f7a2455c55fe998ececc2dabd200182..56bc147f78e0671c4f1a3f1724e0f9e739cddacc 100644

--- a/content/renderer/render_frame_impl.h

+++ b/content/renderer/render_frame_impl.h

@@ -606,7 +606,6 @@ class CONTENT_EXPORT RenderFrameImpl

blink::WebRTCPeerConnectionHandler* handler) override;

blink::WebUserMediaClient* userMediaClient() override;

blink::WebEncryptedMediaClient* encryptedMediaClient() override;

- blink::WebMIDIClient* webMIDIClient() override;

blink::WebString userAgentOverride() override;

blink::WebString doNotTrackValue() override;

bool allowWebGL(bool default_value) override;

@@ -1175,9 +1174,6 @@ class CONTENT_EXPORT RenderFrameImpl

std::unique_ptr<MediaInterfaceProvider> media_interface_provider_;

#endif

- // MidiClient attached to this frame; lazily initialized.

- MidiDispatcher* midi_dispatcher_;

#if defined(OS_ANDROID)

// Manages all media players and sessions in this render frame for

// communicating with the real media player and sessions in the