Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2116723002: Fix Flash assert. (Closed)

Created:
4 years, 5 months ago by waffles
Modified:
4 years, 5 months ago
Reviewers:
Greg K
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Flash assert. Reland of https://codereview.chromium.org/2109873002/. BUG=625201 Committed: https://crrev.com/4d66c388052c2c22791e859e6918e779fa5e4732 Cr-Commit-Position: refs/heads/master@{#403476}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M chrome/browser/component_updater/pepper_flash_component_installer.cc View 2 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
waffles
Greg, PTAL. This is equivalent to https://codereview.chromium.org/2109873002/ but has the function declarations in the correct ...
4 years, 5 months ago (2016-07-01 16:23:44 UTC) #3
Greg K
On 2016/07/01 16:23:44, waffles wrote: > Greg, PTAL. This is equivalent to https://codereview.chromium.org/2109873002/ > but ...
4 years, 5 months ago (2016-07-01 17:08:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2116723002/1
4 years, 5 months ago (2016-07-01 17:15:28 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-01 17:22:02 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-01 17:22:07 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 17:24:10 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d66c388052c2c22791e859e6918e779fa5e4732
Cr-Commit-Position: refs/heads/master@{#403476}

Powered by Google App Engine
This is Rietveld 408576698