third_party/WebKit/Source/platform/graphics/paint/PaintController.h - Issue 2116693002: PaintChunk::id

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/PaintController.h

Issue 2116693002: PaintChunk::id (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@CommitOnTheWay

Patch Set: Address chrishtr's comments. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/frame/FrameView.cpp ('K') | « third_party/WebKit/Source/platform/graphics/paint/PaintChunkerTest.cpp ('k') | third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/paint/PaintController.h

diff --git a/third_party/WebKit/Source/platform/graphics/paint/PaintController.h b/third_party/WebKit/Source/platform/graphics/paint/PaintController.h

index be361ce4511ce4085dac1290e1e2cdfef1233ba1..d95c29fd2e1f1efe720d5d42da4c33e966ef9468 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/PaintController.h

+++ b/third_party/WebKit/Source/platform/graphics/paint/PaintController.h

@@ -60,7 +60,7 @@ public:

// Provide a new set of paint chunk properties to apply to recorded display

// items, for Slimming Paint v2.

- void updateCurrentPaintChunkProperties(const PaintChunkProperties&);

+ void updateCurrentPaintChunkProperties(const PaintChunk::Id*, const PaintChunkProperties&);

// Retrieve the current paint properties.

const PaintChunkProperties& currentPaintChunkProperties() const;

@@ -111,7 +111,7 @@ public:

void beginSkippingCache() { ++m_skippingCacheCount; }

void endSkippingCache() { DCHECK(m_skippingCacheCount > 0); --m_skippingCacheCount; }

- bool skippingCache() const { return m_skippingCacheCount; }

+ bool isSkippingCache() const { return m_skippingCacheCount; }

// Must be called when a painting is finished.

// offsetFromLayoutObject is the offset between the space of the GraphicsLayer which owns this