PaintChunk::id

third_party/WebKit/Source/platform/graphics/paint/PaintController.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PaintController_h
 #define PaintController_h
 
 #include "platform/PlatformExport.h"
 #include "platform/RuntimeEnabledFeatures.h"
 #include "platform/geometry/IntRect.h"
@@ skipping 42 matching lines @@
         DisplayItemClient::endShouldKeepAliveAllClients(this);
 #endif
     }
 
     void invalidateAll();
 
     // These methods are called during painting.
 
     // Provide a new set of paint chunk properties to apply to recorded display
     // items, for Slimming Paint v2.
-    void updateCurrentPaintChunkProperties(const PaintChunkProperties&);
+    void updateCurrentPaintChunkProperties(const PaintChunk::Id*, const PaintChunkProperties&);

[chrishtr, 2016/07/19 17:27:52]

Document that the id is optional, and what happens if it is not present.

 
     // Retrieve the current paint properties.
     const PaintChunkProperties& currentPaintChunkProperties() const;
 
     template <typename DisplayItemClass, typename... Args>
     void createAndAppend(Args&&... args)
     {
         static_assert(WTF::IsSubclass<DisplayItemClass, DisplayItem>::value,
             "Can only createAndAppend subclasses of DisplayItem.");
         static_assert(sizeof(DisplayItemClass) <= kMaximumDisplayItemSize,
@@ skipping 30 matching lines @@
     // Tries to find the cached subsequence corresponding to the given parameters. If found, copies the
     // cache subsequence to the new display list and returns true. Otherwise returns false.
     bool useCachedSubsequenceIfPossible(const DisplayItemClient&);
 
     // True if the last display item is a begin that doesn't draw content.
     bool lastDisplayItemIsNoopBegin() const;
     void removeLastDisplayItem();
 
     void beginSkippingCache() { ++m_skippingCacheCount; }
     void endSkippingCache() { DCHECK(m_skippingCacheCount > 0); --m_skippingCacheCount; }
-    bool skippingCache() const { return m_skippingCacheCount; }
+    bool isSkippingCache() const { return m_skippingCacheCount; }
 
     // Must be called when a painting is finished.
     // offsetFromLayoutObject is the offset between the space of the GraphicsLayer which owns this
     // PaintController and the coordinate space of the owning LayoutObject.
     void commitNewDisplayItems(const LayoutSize& offsetFromLayoutObject = LayoutSize());
 
     // Returns the approximate memory usage, excluding memory likely to be
     // shared with the embedder after copying to WebPaintController.
     // Should only be called right after commitNewDisplayItems.
     size_t approximateUnsharedMemoryUsage() const;
@@ skipping 151 matching lines @@
 
 #if CHECK_DISPLAY_ITEM_CLIENT_ALIVENESS
     // A stack recording subsequence clients that are currently painting.
     Vector<const DisplayItemClient*> m_currentSubsequenceClients;
 #endif
 };
 
 } // namespace blink
 
 #endif // PaintController_h