PaintChunk::id

third_party/WebKit/Source/core/frame/FrameView.cpp

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999 Lars Knoll <knoll@kde.org>
  *                     1999 Antti Koivisto <koivisto@kde.org>
  *                     2000 Dirk Mueller <mueller@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  *           (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
@@ skipping 88 matching lines @@
 #include "platform/TracedValue.h"
 #include "platform/fonts/FontCache.h"
 #include "platform/geometry/DoubleRect.h"
 #include "platform/geometry/FloatRect.h"
 #include "platform/geometry/LayoutRect.h"
 #include "platform/graphics/GraphicsContext.h"
 #include "platform/graphics/GraphicsLayer.h"
 #include "platform/graphics/GraphicsLayerDebugInfo.h"
 #include "platform/graphics/paint/CullRect.h"
 #include "platform/graphics/paint/PaintController.h"
+#include "platform/graphics/paint/ScopedPaintChunkProperties.h"
 #include "platform/scheduler/CancellableTaskFactory.h"
 #include "platform/scroll/ScrollAnimatorBase.h"
 #include "platform/scroll/ScrollbarTheme.h"
 #include "platform/text/TextStream.h"
 #include "public/platform/WebDisplayItemList.h"
 #include "public/platform/WebFrameScheduler.h"
 #include "wtf/CurrentTime.h"
 #include "wtf/PtrUtil.h"
 #include "wtf/StdLibExtras.h"
 #include "wtf/TemporaryChange.h"
@@ skipping 2517 matching lines @@
             layoutViewItem.layer()->clearNeedsRepaintRecursively();
     });
 }
 
 void FrameView::synchronizedPaintRecursively(GraphicsLayer* graphicsLayer)
 {
     if (graphicsLayer->drawsContent()) {
         // Usually this is not needed because the PaintLayer will setup the chunk properties
         // altogether. However in debug builds the GraphicsLayer could paint debug background before
         // we ever reach the PaintLayer.
+        Optional<ScopedPaintChunkProperties> scopedPaintChunkProperties;
         if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
             PaintChunkProperties properties;
             properties.transform = m_rootTransform;
             properties.clip = m_rootClip;
             properties.effect = m_rootEffect;
-            graphicsLayer->getPaintController().updateCurrentPaintChunkProperties(properties);
+            scopedPaintChunkProperties.emplace(graphicsLayer->getPaintController(), *layoutView(), DisplayItem::DebugRedFill, properties);

[chrishtr, 2016/07/19 17:27:52]

It's weird that there is a reference to the debug red fill here, but it actually
appears two levels down in the call stack.

How about pushing the ScopedPaintChunkProperties down into
GraphicsLayer::paintWithoutCommit?

[Xianzhu, 2016/07/19 21:57:48]

This had been weird before this CL. To push this down we need to pass the
FrameView's paint properties to GraphicsLayer::paint().

Can we just remove the red debug fill? I vaguely remember we have similar
mechanism elsewhere (in cc? in blue or purple?).

[chrishtr, 2016/07/19 23:42:27]

In debug builds cc does indeed show a color underneath underpainted areas. I
agree, let's just remove it.

         }
         graphicsLayer->paint(nullptr);
-        if (RuntimeEnabledFeatures::slimmingPaintV2Enabled())
-            graphicsLayer->getPaintController().updateCurrentPaintChunkProperties(PaintChunkProperties());
     }
 
     if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
         if (GraphicsLayer* maskLayer = graphicsLayer->maskLayer())
             synchronizedPaintRecursively(maskLayer);
         if (GraphicsLayer* contentsClippingMaskLayer = graphicsLayer->contentsClippingMaskLayer())
             synchronizedPaintRecursively(contentsClippingMaskLayer);
         if (GraphicsLayer* replicaLayer = graphicsLayer->replicaLayer())
             synchronizedPaintRecursively(replicaLayer);
     }
@@ skipping 1615 matching lines @@
 }
 
 bool FrameView::canThrottleRendering() const
 {
     if (!RuntimeEnabledFeatures::renderingPipelineThrottlingEnabled())
         return false;
     return m_subtreeThrottled || (m_hiddenForThrottling && m_crossOriginForThrottling);
 }
 
 } // namespace blink