Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2116673002: [ios] Moved WebUI provider code to ios/web. (Closed)

Created:
4 years, 5 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 5 months ago
Reviewers:
Jackie Quinn
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Patrick Dubroy, Aaron Boodman, dbeam+watch-history_chromium.org, pam+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Moved WebUI provider code to ios/web. Some old headers are temporary left as they are used in downstream code. BUG=524467 Committed: https://crrev.com/9c7ad7c7d54c468e47c53b502f06c7d9094a97c7 Cr-Commit-Position: refs/heads/master@{#403422}

Patch Set 1 #

Patch Set 2 : Self review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -308 lines) Patch
M ios/chrome/browser/browser_state/chrome_browser_state.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/about_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/crashes_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/crashes_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/webui/flags_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/flags_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/webui/gcm/gcm_internals_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/gcm/gcm_internals_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/webui/history/browsing_history_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/history/browsing_history_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/history/history_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/history/history_ui.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/history/metrics_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/history/metrics_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/mojo_web_ui_ios_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/webui/net_export/net_export_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/net_export/net_export_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/sync_internals/sync_internals_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/sync_internals/sync_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/version_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/version_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/version_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/version_ui.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/provider/ios_provider_web.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/public/provider/web/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ios/public/provider/web/web_ui_ios.h View 1 1 chunk +3 lines, -77 lines 0 comments Download
M ios/public/provider/web/web_ui_ios_controller.h View 1 1 chunk +3 lines, -32 lines 0 comments Download
D ios/public/provider/web/web_ui_ios_controller.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M ios/public/provider/web/web_ui_ios_controller_factory.h View 1 1 chunk +3 lines, -25 lines 0 comments Download
M ios/public/provider/web/web_ui_ios_message_handler.h View 1 1 chunk +3 lines, -54 lines 0 comments Download
D ios/public/provider/web/web_ui_ios_message_handler.cc View 1 chunk +0 lines, -48 lines 0 comments Download
M ios/web/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M ios/web/ios_web.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
A + ios/web/public/webui/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ios/web/public/webui/web_ui_ios.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ios/web/public/webui/web_ui_ios_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ios/web/public/webui/web_ui_ios_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ios/web/public/webui/web_ui_ios_controller_factory.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ios/web/public/webui/web_ui_ios_message_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ios/web/public/webui/web_ui_ios_message_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 2 chunks +1 line, -1 line 0 comments Download
M ios/web/webui/web_ui_ios_controller_factory_registry.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/webui/web_ui_ios_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/webui/web_ui_ios_impl.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/web/webui/web_ui_mojo_inttest.mm View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2116673002/1
4 years, 5 months ago (2016-06-30 21:45:15 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2116673002/20001
4 years, 5 months ago (2016-06-30 21:53:33 UTC) #4
Eugene But (OOO till 7-30)
Could you please CQ if this LG
4 years, 5 months ago (2016-06-30 22:58:13 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-30 22:58:26 UTC) #8
Jackie Quinn
lgtm
4 years, 5 months ago (2016-07-01 07:21:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2116673002/20001
4 years, 5 months ago (2016-07-01 07:21:47 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-01 07:26:10 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 07:28:38 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/9c7ad7c7d54c468e47c53b502f06c7d9094a97c7
Cr-Commit-Position: refs/heads/master@{#403422}

Powered by Google App Engine
This is Rietveld 408576698