Test for BrowserPlugin-based WebView Focus

content/browser/frame_host/render_widget_host_view_child_frame.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_WIDGET_HOST_VIEW_CHILD_FRAME_H_
 #define CONTENT_BROWSER_FRAME_HOST_RENDER_WIDGET_HOST_VIEW_CHILD_FRAME_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 171 matching lines @@
   // Exposed for tests.
   bool IsChildFrameForTesting() const override;
   cc::SurfaceId SurfaceIdForTesting() const override;
   CrossProcessFrameConnector* FrameConnectorForTesting() const {
     return frame_connector_;
   }
 
   void RegisterSurfaceNamespaceId();
   void UnregisterSurfaceNamespaceId();
 
+  uint32_t surface_frame_count() const { return surface_frame_count_; }
+
  protected:
   friend class RenderWidgetHostView;
   friend class RenderWidgetHostViewChildFrameTest;
   friend class RenderWidgetHostViewGuestSurfaceTest;
 
   // Clears current compositor surface, if one is in use.
   void ClearCompositorSurfaceIfNecessary();
 
   void ProcessFrameSwappedCallbacks();
 
   // The last scroll offset of the view.
   gfx::Vector2dF last_scroll_offset_;
 
   // Members will become private when RenderWidgetHostViewGuest is removed.
   // The model object.
   RenderWidgetHostImpl* host_;
 
   // Surface-related state.
   std::unique_ptr<cc::SurfaceIdAllocator> id_allocator_;
   std::unique_ptr<cc::SurfaceFactory> surface_factory_;
   cc::SurfaceId surface_id_;
   uint32_t next_surface_sequence_;
   uint32_t last_output_surface_id_;
   gfx::Size current_surface_size_;
   float current_surface_scale_factor_;
   gfx::Rect last_screen_rect_;
   uint32_t ack_pending_count_;
+  uint32_t surface_frame_count_;

[Charlie Reis, 2016/07/06 18:28:49]

Seems mildly unfortunate to have to track this in all builds just to support
tests.  That said, I'd much rather have tests than not add this.  :)

Just thought I'd check if there's another way to do the waiting without adding
this counter.  If not, I'm ok with it.

[wjmaclean, 2016/07/06 19:49:31]

Agreed. kenrb@ and I haven't thought of another way, and even if it was, it
would likely be an observer or some such thing that would add at least as much
state/overhead as this.

[Charlie Reis, 2016/07/06 20:17:13]

Can we make it a bool instead of a counter?  The only use of it is to compare it
to zero, so something like has_received_surface_frame_ might be simpler.  (Or
are there plans to compare against other values soon?)

   cc::ReturnedResourceArray surface_returned_resources_;
 
   // frame_connector_ provides a platform abstraction. Messages
   // sent through it are routed to the embedding renderer process.
   CrossProcessFrameConnector* frame_connector_;
 
   base::WeakPtr<RenderWidgetHostViewChildFrame> AsWeakPtr() {
     return weak_factory_.GetWeakPtr();
   }
 
@@ skipping 15 matching lines @@
   // The surface id namespace of the parent RenderWidgetHostView.  0 if none.
   uint32_t parent_surface_id_namespace_;
 
   base::WeakPtrFactory<RenderWidgetHostViewChildFrame> weak_factory_;
   DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewChildFrame);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_RENDER_WIDGET_HOST_VIEW_CHILD_FRAME_H_