Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2116653003: [Translate] Honors "IsTooOftenDenied" policy in incognito bubble (Closed)

Created:
4 years, 5 months ago by ftang
Modified:
4 years, 5 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Translate Bubble now honors the "IsTooOftenDenied" policy in incognito. BUG=624984 Committed: https://crrev.com/711aae13e655054eb44f00bcb246e717a425d27b Cr-Commit-Position: refs/heads/master@{#403994}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M chrome/browser/translate/chrome_translate_client.cc View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2116653003/1
4 years, 5 months ago (2016-06-30 23:59:57 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-01 00:42:23 UTC) #4
ftang
4 years, 5 months ago (2016-07-01 17:54:40 UTC) #6
groby-ooo-7-16
This still does not mean that behavior is in sync with the InfoBar. The InfoBar ...
4 years, 5 months ago (2016-07-01 19:10:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2116653003/1
4 years, 5 months ago (2016-07-06 20:50:53 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 00:03:50 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 00:03:59 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 00:06:25 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/711aae13e655054eb44f00bcb246e717a425d27b
Cr-Commit-Position: refs/heads/master@{#403994}

Powered by Google App Engine
This is Rietveld 408576698