Cards Clicked Metrics

tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 005fb5c89b12afa7e01d340d51da86dda117585b..237f753f400b270b85d6c1d0a0342b6bb2f03a2f 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -6816,6 +6816,26 @@ other types of suffix sets.
   <summary>Http response codes in NetworkLocationRequest.</summary>
 </histogram>
 
+<histogram name="GoogleNow.Card.Button.Clicked0"
+    enum="GoogleNowCardButtonClicked0">
+  <owner>robliao@chromium.org</owner>
+  <owner>skare@chromium.org</owner>
+  <summary>Types of cards which received an index 0 button click.</summary>
+</histogram>
+
+<histogram name="GoogleNow.Card.Button.Clicked1"
+    enum="GoogleNowCardButtonClicked1">
+  <owner>robliao@chromium.org</owner>
+  <owner>skare@chromium.org</owner>
+  <summary>Types of cards which received an index 1 button click.</summary>
+</histogram>
+
+<histogram name="GoogleNow.Card.Clicked" enum="GoogleNowCardClicked">
+  <owner>robliao@chromium.org</owner>
+  <owner>skare@chromium.org</owner>
+  <summary>Types of cards which received an notification click.</summary>

[Ilya Sherman, 2014/03/26 00:32:50]

nit: "an notification" -> "a notification"

[robliao, 2014/03/26 00:42:53]

Done.

+</histogram>
+
 <histogram name="GoogleNow.Event" enum="GoogleNowEvent">
   <owner>robliao@chromium.org</owner>
   <owner>skare@chromium.org</owner>
@@ -32794,6 +32814,27 @@ other types of suffix sets.
   <int value="6" label="UNSET"/>
 </enum>
 
+<enum name="GoogleNowCardButtonClicked0" type="int">
+  <summary>
+    Card Types where button 0 is clicked. See GoogleNowCardButtonClicked0 in
+    chrome/browser/resources/google_now/background.js.
+  </summary>
+</enum>
+
+<enum name="GoogleNowCardButtonClicked1" type="int">
+  <summary>
+    Card Types where button 1 is clicked. See GoogleNowCardButtonClicked1 in
+    chrome/browser/resources/google_now/background.js.
+  </summary>
+</enum>
+
+<enum name="GoogleNowCardClicked" type="int">
+  <summary>
+    Card Types where card itself is clicked. See GoogleNowCardClicked in
+    chrome/browser/resources/google_now/background.js.
+  </summary>
+</enum>

[Ilya Sherman, 2014/03/26 00:32:50]

Do these need to be three separate enums, or can there just be a single
GoogleNowCard enum?

[robliao, 2014/03/26 00:42:53]

We have two variables we need to track, type and button ID. If there's a two
dimensional histogram, we could use that.

[Ilya Sherman, 2014/03/26 03:55:41]

I don't understand what you mean.  Say you're interested in data about the
TRAFFIC card.  Is it going to have a different value in each of these enums?  If
so, why?  It would help if these enums had at least *some* labels, rather than
being completely empty.  I understand that you want to expand them later, but
presumably some are already known -- right?

[robliao, 2014/03/27 00:51:51]

Ah, I see what you mean. Changed.
On 2014/03/26 03:55:41, Ilya Sherman wrote:

+
 <enum name="GoogleNowEvent" type="int">
   <summary>
     Events in Google Now component extension. See GoogleNowEvent in