Issue 211663002: Refactoring: Get rid of HTMLImportLoaerClient

Issue 211663002: Refactoring: Get rid of HTMLImportLoaerClient (Closed)

Created:
6 years, 9 months ago by Hajime Morrita

Modified:
6 years, 9 months ago

Reviewers:
dglazkov, dominicc (has gone to gerrit)

CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Refactoring: Get rid of HTMLImportLoaerClient This indirection doesn't help and just introduces unnecessary complexity. BUG=356257 TEST=none R=dominicc@chromium.org,dglazkov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170006

Patch Set 1 #

Patch Set 2 : Updated #

Total comments: 1

Patch Set 3 : Fixed typo and bad grammar #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -80 lines)			Patch
M	Source/core/core.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/html/imports/HTMLImport.h	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/core/html/imports/HTMLImportChild.h	View		4 chunks	+3 lines, -5 lines	0 comments	Download
M	Source/core/html/imports/HTMLImportChild.cpp	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/html/imports/HTMLImportLoader.h	View	1	4 chunks	+8 lines, -10 lines	0 comments	Download
M	Source/core/html/imports/HTMLImportLoader.cpp	View	1	3 chunks	+15 lines, -14 lines	0 comments	Download
D	Source/core/html/imports/HTMLImportLoaderClient.h	View		1 chunk	+0 lines, -44 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

dominicc (has gone to gerrit)

LGTM modulo inline comment. Also spelling in the change description: Loaer -> Loader. https://codereview.chromium.org/211663002/diff/30001/Source/core/html/imports/HTMLImport.h File ...

6 years, 9 months ago (2014-03-26 01:15:46 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/211663002/90001

6 years, 9 months ago (2014-03-26 01:47:39 UTC) #4

Message was sent while issue was closed.

Change committed as 170006

Expand Messages | Collapse Messages