Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: extensions/renderer/programmatic_script_injector.h

Issue 2116613002: Prevent duplicate content script injection defined in manifest.json (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed code review comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/test/data/extensions/api_test/content_scripts/duplicate_script_injection/manifest.json ('K') | « chrome/test/data/extensions/api_test/content_scripts/duplicate_script_injection/test.js ('k') | extensions/renderer/programmatic_script_injector.cc » ('j') | extensions/renderer/scripts_run_info.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/programmatic_script_injector.h
diff --git a/extensions/renderer/programmatic_script_injector.h b/extensions/renderer/programmatic_script_injector.h
index 885c3b12151cc2fc9b4d5ecf686b0e40ddc198cb..ac19a8082885055d7b7d648b77f48ff58b457528 100644
--- a/extensions/renderer/programmatic_script_injector.h
+++ b/extensions/renderer/programmatic_script_injector.h
@@ -40,9 +40,12 @@ class ProgrammaticScriptInjector : public ScriptInjector {
blink::WebLocalFrame* web_frame,
int tab_id) const override;
std::vector<blink::WebScriptSource> GetJsSources(
- UserScript::RunLocation run_location) const override;
+ UserScript::RunLocation run_location,
+ ScriptsRunInfo* scripts_run_info) const override;
+
std::vector<std::string> GetCssSources(
- UserScript::RunLocation run_location) const override;
+ UserScript::RunLocation run_location,
+ ScriptsRunInfo* scripts_run_info) const override;
void GetRunInfo(ScriptsRunInfo* scripts_run_info,
UserScript::RunLocation run_location) const override;
void OnInjectionComplete(std::unique_ptr<base::Value> execution_result,
« chrome/test/data/extensions/api_test/content_scripts/duplicate_script_injection/manifest.json ('K') | « chrome/test/data/extensions/api_test/content_scripts/duplicate_script_injection/test.js ('k') | extensions/renderer/programmatic_script_injector.cc » ('j') | extensions/renderer/scripts_run_info.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698