chrome/test/data/extensions/api_test/content_scripts/duplicate_script_injection/test.js - Issue 2116613002: Prevent duplicate content script injection defined in manifest.json

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/content_scripts/duplicate_script_injection/test.js

Issue 2116613002: Prevent duplicate content script injection defined in manifest.json (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tests Added Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/extensions/api_test/content_scripts/duplicate_script_injection/test.css ('K') | « chrome/test/data/extensions/api_test/content_scripts/duplicate_script_injection/test.css ('k') | extensions/renderer/programmatic_script_injector.h » ('j') | extensions/renderer/user_script_injector.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/content_scripts/duplicate_script_injection/test.js

diff --git a/ios/web/shell/test/shell_test.mm b/chrome/test/data/extensions/api_test/content_scripts/duplicate_script_injection/test.js

similarity index 54%

copy from ios/web/shell/test/shell_test.mm

copy to chrome/test/data/extensions/api_test/content_scripts/duplicate_script_injection/test.js

index 5b4cddc172c1c4cafc6884d64c1f2cf5e1514915..d634cf6a55ce8c95b4be2cec0c347086b04d27d1 100644

--- a/ios/web/shell/test/shell_test.mm

+++ b/chrome/test/data/extensions/api_test/content_scripts/duplicate_script_injection/test.js

@@ -2,11 +2,8 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-#import <UIKit/UIKit.h>

-#import <XCTest/XCTest.h>

+var el = document.createElement('div');

+el.className = 'test-duplicate-script-injection';

+document.querySelector("body").appendChild(el);

Devlin 2016/07/11 23:45:50 nit: prefer single-quotes in js.

catmullings 2016/07/12 22:23:26 Done.

-@interface EmptyFile : NSObject

-@end

-@implementation EmptyFile

-@end