extensions/renderer/programmatic_script_injector.h - Issue 2116613002: Prevent duplicate content script injection defined in manifest.json

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/programmatic_script_injector.h

Issue 2116613002: Prevent duplicate content script injection defined in manifest.json (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed code review comments from patch 7 Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/extensions/api_test/content_scripts/duplicate_script_injection/should_run_twice.js ('K') | « chrome/test/data/extensions/api_test/content_scripts/duplicate_script_injection/should_run_twice.js ('k') | extensions/renderer/programmatic_script_injector.cc » ('j') | extensions/renderer/user_script_injector.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/programmatic_script_injector.h

diff --git a/extensions/renderer/programmatic_script_injector.h b/extensions/renderer/programmatic_script_injector.h

index 885c3b12151cc2fc9b4d5ecf686b0e40ddc198cb..ac19a8082885055d7b7d648b77f48ff58b457528 100644

--- a/extensions/renderer/programmatic_script_injector.h

+++ b/extensions/renderer/programmatic_script_injector.h

@@ -40,9 +40,12 @@ class ProgrammaticScriptInjector : public ScriptInjector {

blink::WebLocalFrame* web_frame,

int tab_id) const override;

std::vector<blink::WebScriptSource> GetJsSources(

- UserScript::RunLocation run_location) const override;

+ UserScript::RunLocation run_location,

+ ScriptsRunInfo* scripts_run_info) const override;

Devlin 2016/07/19 23:10:36 delete this blank line

catmullings 2016/07/20 16:00:36 Done.

std::vector<std::string> GetCssSources(

- UserScript::RunLocation run_location) const override;

+ UserScript::RunLocation run_location,

+ ScriptsRunInfo* scripts_run_info) const override;

void GetRunInfo(ScriptsRunInfo* scripts_run_info,

UserScript::RunLocation run_location) const override;

void OnInjectionComplete(std::unique_ptr<base::Value> execution_result,