chrome/test/data/extensions/api_test/content_scripts/duplicate_script_injection/should_run_twice.js - Issue 2116613002: Prevent duplicate content script injection defined in manifest.json

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/content_scripts/duplicate_script_injection/should_run_twice.js

Issue 2116613002: Prevent duplicate content script injection defined in manifest.json (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Minor followup fix to patch 5 Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/extensions/api_test/content_scripts/duplicate_script_injection/manifest.json ('K') | « chrome/test/data/extensions/api_test/content_scripts/duplicate_script_injection/manifest.json ('k') | chrome/test/data/extensions/api_test/content_scripts/duplicate_script_injection/test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/content_scripts/duplicate_script_injection/should_run_twice.js

diff --git a/ios/web/test/test_url_constants.cc b/chrome/test/data/extensions/api_test/content_scripts/duplicate_script_injection/should_run_twice.js

similarity index 57%

copy from ios/web/test/test_url_constants.cc

copy to chrome/test/data/extensions/api_test/content_scripts/duplicate_script_injection/should_run_twice.js

index e867552a56d50a9dd0784d5bd0c1fb363c13c70a..4e62e248f7e506af36cdd62c6cedb9c2826ee87f 100644

--- a/ios/web/test/test_url_constants.cc

+++ b/chrome/test/data/extensions/api_test/content_scripts/duplicate_script_injection/should_run_twice.js

@@ -2,10 +2,9 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-#include "ios/web/test/test_url_constants.h"

+var elem = document.createElement('div');

+elem.className = 'injected-twice';

Devlin 2016/07/19 16:09:00 here, too, let's have the divs have parity and mir

catmullings 2016/07/19 17:10:51 Done.

+document.querySelector("body").appendChild(elem);

Devlin 2016/07/19 16:09:00 prefer single quotes in js

catmullings 2016/07/19 17:10:51 Done.

-namespace web {

-const char kTestWebUIScheme[] = "testwebui";

-} // namespace web