Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Side by Side Diff: extensions/renderer/script_injector.h

Issue 2116613002: Prevent duplicate content script injection defined in manifest.json (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed code review comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_RENDERER_SCRIPT_INJECTOR_H_ 5 #ifndef EXTENSIONS_RENDERER_SCRIPT_INJECTOR_H_
6 #define EXTENSIONS_RENDERER_SCRIPT_INJECTOR_H_ 6 #define EXTENSIONS_RENDERER_SCRIPT_INJECTOR_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 58
59 // Returns true if the script should execute on the given |frame|. 59 // Returns true if the script should execute on the given |frame|.
60 virtual PermissionsData::AccessType CanExecuteOnFrame( 60 virtual PermissionsData::AccessType CanExecuteOnFrame(
61 const InjectionHost* injection_host, 61 const InjectionHost* injection_host,
62 blink::WebLocalFrame* web_frame, 62 blink::WebLocalFrame* web_frame,
63 int tab_id) const = 0; 63 int tab_id) const = 0;
64 64
65 // Returns the javascript sources to inject at the given |run_location|. 65 // Returns the javascript sources to inject at the given |run_location|.
66 // Only called if ShouldInjectJs() is true. 66 // Only called if ShouldInjectJs() is true.
67 virtual std::vector<blink::WebScriptSource> GetJsSources( 67 virtual std::vector<blink::WebScriptSource> GetJsSources(
68 UserScript::RunLocation run_location) const = 0; 68 UserScript::RunLocation run_location,
69 ScriptsRunInfo* scripts_run_info) const = 0;
69 70
70 // Returns the css to inject at the given |run_location|. 71 // Returns the css to inject at the given |run_location|.
71 // Only called if ShouldInjectCss() is true. 72 // Only called if ShouldInjectCss() is true.
72 virtual std::vector<std::string> GetCssSources( 73 virtual std::vector<std::string> GetCssSources(
73 UserScript::RunLocation run_location) const = 0; 74 UserScript::RunLocation run_location,
75 ScriptsRunInfo* scripts_run_info) const = 0;
74 76
75 // Fill scriptrs run info based on information about injection. 77 // Fill scriptrs run info based on information about injection.
76 virtual void GetRunInfo( 78 virtual void GetRunInfo(
77 ScriptsRunInfo* scripts_run_info, 79 ScriptsRunInfo* scripts_run_info,
78 UserScript::RunLocation run_location) const = 0; 80 UserScript::RunLocation run_location) const = 0;
79 81
80 // Notifies the script that injection has completed, with a possibly-populated 82 // Notifies the script that injection has completed, with a possibly-populated
81 // list of results (depending on whether or not ExpectsResults() was true). 83 // list of results (depending on whether or not ExpectsResults() was true).
82 // |render_frame| contains the render frame, or null if the frame was 84 // |render_frame| contains the render frame, or null if the frame was
83 // invalidated. 85 // invalidated.
84 virtual void OnInjectionComplete( 86 virtual void OnInjectionComplete(
85 std::unique_ptr<base::Value> execution_result, 87 std::unique_ptr<base::Value> execution_result,
86 UserScript::RunLocation run_location, 88 UserScript::RunLocation run_location,
87 content::RenderFrame* render_frame) = 0; 89 content::RenderFrame* render_frame) = 0;
88 90
89 // Notifies the script that injection will never occur. 91 // Notifies the script that injection will never occur.
90 // |render_frame| contains the render frame, or null if the frame was 92 // |render_frame| contains the render frame, or null if the frame was
91 // invalidated. 93 // invalidated.
92 virtual void OnWillNotInject(InjectFailureReason reason, 94 virtual void OnWillNotInject(InjectFailureReason reason,
93 content::RenderFrame* render_frame) = 0; 95 content::RenderFrame* render_frame) = 0;
94 }; 96 };
95 97
96 } // namespace extensions 98 } // namespace extensions
97 99
98 #endif // EXTENSIONS_RENDERER_SCRIPT_INJECTOR_H_ 100 #endif // EXTENSIONS_RENDERER_SCRIPT_INJECTOR_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698