Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2116593004: Add script which gathers JSON output from a Swarming task's shards. (Closed)

Created:
4 years, 5 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 5 months ago
Reviewers:
Zhenyao Mo, Vadim Sh.
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, Vadim Sh., Geoff Lang, Jamie Madill, Corentin Wallez
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add script which gathers JSON output from a Swarming task's shards. This will be used to periodically gather per-test run times for various test suites, to improve the sharding distribution. Check in the data for a recent run of webgl2_conformance_tests. Reference this from the Swarming invocations. BUG=352807 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel NOTRY=true Committed: https://crrev.com/fcc0a67a2b4f98248b2434815327bf73bdb8b48b Cr-Commit-Position: refs/heads/master@{#404487}

Patch Set 1 #

Patch Set 2 : Load WebGL 2.0 conformance test times from the isolate. #

Total comments: 6

Patch Set 3 : Addressed review feedback. Formatted generated JSON. #

Patch Set 4 : Rebased and re-scraped test times. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3643 lines, -23 lines) Patch
A content/test/data/gpu/webgl2_conformance_tests_output.json View 1 2 3 1 chunk +3353 lines, -0 lines 0 comments Download
A content/test/gpu/gather_swarming_json_results.py View 1 2 1 chunk +234 lines, -0 lines 0 comments Download
M content/test/gpu/generate_buildbot_json.py View 1 2 chunks +10 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.gpu.fyi.json View 1 23 chunks +46 lines, -23 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
Ken Russell (switch to Gerrit)
Mo: please review. Vadim, ANGLE folks: FYI; any comments are welcome. Thanks.
4 years, 5 months ago (2016-07-01 20:05:50 UTC) #3
Zhenyao Mo
This is really great LGTM https://codereview.chromium.org/2116593004/diff/20001/content/test/gpu/gather_swarming_json_results.py File content/test/gpu/gather_swarming_json_results.py (right): https://codereview.chromium.org/2116593004/diff/20001/content/test/gpu/gather_swarming_json_results.py#newcode81 content/test/gpu/gather_swarming_json_results.py:81: self.BASE_BUILD_URL = self.BASE_URL + ...
4 years, 5 months ago (2016-07-01 23:29:39 UTC) #4
Vadim Sh.
https://codereview.chromium.org/2116593004/diff/20001/content/test/gpu/gather_swarming_json_results.py File content/test/gpu/gather_swarming_json_results.py (right): https://codereview.chromium.org/2116593004/diff/20001/content/test/gpu/gather_swarming_json_results.py#newcode68 content/test/gpu/gather_swarming_json_results.py:68: hashes = [] technically these are not hashes but ...
4 years, 5 months ago (2016-07-02 01:19:52 UTC) #6
Ken Russell (switch to Gerrit)
Note this is blocked on the fix for http://crbug.com/625363 . https://codereview.chromium.org/2116593004/diff/20001/content/test/gpu/gather_swarming_json_results.py File content/test/gpu/gather_swarming_json_results.py (right): https://codereview.chromium.org/2116593004/diff/20001/content/test/gpu/gather_swarming_json_results.py#newcode68 ...
4 years, 5 months ago (2016-07-02 03:17:01 UTC) #7
Ken Russell (switch to Gerrit)
With https://chromium-review.googlesource.com/358515 rolled in this should now pass. CQ'ing.
4 years, 5 months ago (2016-07-08 18:44:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2116593004/60001
4 years, 5 months ago (2016-07-08 18:45:40 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, no build URL)
4 years, 5 months ago (2016-07-08 20:03:05 UTC) #13
Ken Russell (switch to Gerrit)
On 2016/07/08 20:03:05, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 5 months ago (2016-07-08 21:05:06 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2116593004/60001
4 years, 5 months ago (2016-07-08 21:06:03 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-08 21:12:52 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 21:14:57 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/fcc0a67a2b4f98248b2434815327bf73bdb8b48b
Cr-Commit-Position: refs/heads/master@{#404487}

Powered by Google App Engine
This is Rietveld 408576698