Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1048)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

Issue 2116593002: Confirm ongoing IME composition at the right render widget in response to mouse click/tap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_aura.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
index 995e81c034aa87c7212a4a2e62e9283b92f1b7db..8c0fc5d50088d5c6edaae911f59fb9ed1984fc3b 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
@@ -4216,4 +4216,21 @@ TEST_F(InputMethodResultAuraTest, InsertText) {
}
}
+// This test makes a specific child frame's view active and then forces the tab
+// view end current IME composition session by sending out an IME confirm
Charlie Reis 2016/06/30 18:43:12 nit: I think a word is missing here? "force the ta
EhsanK 2016/06/30 19:26:29 Acknowledged.
+// composition IPC. The test then verifies that the message is sent to the
+// active widget's process.
+TEST_F(InputMethodResultAuraTest, FinishImeCompositionSession) {
+ base::Closure ime_finish_session_call =
+ base::Bind(&RenderWidgetHostViewAura::FinishImeCompositionSession,
+ base::Unretained(tab_view()));
+ for (auto index : active_view_sequence_) {
+ ActivateViewForTextInputManager(views_[index], ui::TEXT_INPUT_TYPE_TEXT);
+ SetHasCompositionTextToTrue();
+ EXPECT_TRUE(!!RunAndReturnIPCSent(ime_finish_session_call,
+ processes_[index],
+ InputMsg_ImeConfirmComposition::ID));
+ }
+}
+
} // namespace content
« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_aura.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698