Confirm ongoing IME composition at the right render widget in response to mouse click/tap.

Confirm ongoing IME composition at the right render widget in response to mouse click/tap.

After CL: https://codereview.chromium.org/2092103002/ all IME result methods are
being routed to the right RenderWidget. Similarly, when an IME session is closed
on the browser side due to a click or tap, the right widget should be notifed
by receiving an IME confirm composition with empty text. Currently, this IPC is
sent to the tab's RenderWidget regardless of what the active widget is.

This CL will route the IPC to the right widget and adds a unit test for this purpose.

BUG=578168, 602723
Committed: https://crrev.com/bbf1ae258c9f56929493ba5bfeca274a506b08b1
Cr-Commit-Position: refs/heads/master@{#403273}

[EhsanK, 2016-06-30 18:28:46]

ekaramad@chromium.org changed reviewers:
+ creis@chromium.org, kenrb@chromium.org

[EhsanK, 2016-06-30 18:28:47]

Hello and sorry for yet another CL on IME. I think we are getting close to
finishing this. Please take a look.

Note:
Maybe this change should have been part of the routing IME result methods (link
in description) since it is very similar. But the IPC is not due to a call from
InputMethod but rather, a response to canceling the composition due to a mouse
click. So maybe it should have been uploaded as a separate CL anyway.

Thanks.

[Charlie Reis, 2016-06-30 18:43:12]

[+site-isolation-reviews]

On 2016/06/30 18:28:47, EhsanK wrote:
> Hello and sorry for yet another CL on IME. I think we are getting close to
> finishing this. Please take a look.
> 
> Note:
> Maybe this change should have been part of the routing IME result methods
(link
> in description) since it is very similar. But the IPC is not due to a call
from
> InputMethod but rather, a response to canceling the composition due to a mouse
> click. So maybe it should have been uploaded as a separate CL anyway.
> 
> Thanks.

No need to apologize!  Small CLs like this are much easier to review.  :)

LGTM.

https://codereview.chromium.org/2116593002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
(right):

https://codereview.chromium.org/2116593002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_aura_unittest.cc:4220: //
view end current IME composition session by sending out an IME confirm
nit: I think a word is missing here?
"force the tab view end current"

[EhsanK, 2016-06-30 19:26:12]

The CQ bit was checked by ekaramad@chromium.org to run a CQ dry run

[EhsanK, 2016-06-30 19:26:30]

Thanks for the reviews!

https://codereview.chromium.org/2116593002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
(right):

https://codereview.chromium.org/2116593002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_aura_unittest.cc:4220: //
view end current IME composition session by sending out an IME confirm
On 2016/06/30 18:43:12, Charlie Reis wrote:
> nit: I think a word is missing here?
> "force the tab view end current"

Acknowledged.

[commit-bot: I haz the power, 2016-06-30 19:26:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 20:24:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 20:24:52]

Dry run: This issue passed the CQ dry run.

[EhsanK, 2016-06-30 20:31:14]

The CQ bit was checked by ekaramad@chromium.org

[EhsanK, 2016-06-30 20:31:15]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org
Link to the patchset: https://codereview.chromium.org/2116593002/#ps20001
(title: "Addressed creis@'s comment")

[commit-bot: I haz the power, 2016-06-30 20:32:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 20:39:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-30 20:39:33]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-30 20:41:56]

Description was changed from

==========
Confirm ongoing IME composition at the right render widget in response to mouse
click/tap.

After CL: https://codereview.chromium.org/2092103002/ all IME result methods are
being routed to the right RenderWidget. Similarly, when an IME session is closed
on the browser side due to a click or tap, the right widget should be notifed
by receiving an IME confirm composition with empty text. Currently, this IPC is
sent to the tab's RenderWidget regardless of what the active widget is.

This CL will route the IPC to the right widget and adds a unit test for this
purpose.

BUG=578168
==========

to

==========
Confirm ongoing IME composition at the right render widget in response to mouse
click/tap.

After CL: https://codereview.chromium.org/2092103002/ all IME result methods are
being routed to the right RenderWidget. Similarly, when an IME session is closed
on the browser side due to a click or tap, the right widget should be notifed
by receiving an IME confirm composition with empty text. Currently, this IPC is
sent to the tab's RenderWidget regardless of what the active widget is.

This CL will route the IPC to the right widget and adds a unit test for this
purpose.

BUG=578168

Committed: https://crrev.com/bbf1ae258c9f56929493ba5bfeca274a506b08b1
Cr-Commit-Position: refs/heads/master@{#403273}
==========

[commit-bot: I haz the power, 2016-06-30 20:41:57]

Patchset 2 (id:??) landed as
https://crrev.com/bbf1ae258c9f56929493ba5bfeca274a506b08b1
Cr-Commit-Position: refs/heads/master@{#403273}

[EhsanK, 2016-07-05 15:19:11]

Description was changed from

==========
Confirm ongoing IME composition at the right render widget in response to mouse
click/tap.

After CL: https://codereview.chromium.org/2092103002/ all IME result methods are
being routed to the right RenderWidget. Similarly, when an IME session is closed
on the browser side due to a click or tap, the right widget should be notifed
by receiving an IME confirm composition with empty text. Currently, this IPC is
sent to the tab's RenderWidget regardless of what the active widget is.

This CL will route the IPC to the right widget and adds a unit test for this
purpose.

BUG=578168

Committed: https://crrev.com/bbf1ae258c9f56929493ba5bfeca274a506b08b1
Cr-Commit-Position: refs/heads/master@{#403273}
==========

to

==========
Confirm ongoing IME composition at the right render widget in response to mouse
click/tap.

After CL: https://codereview.chromium.org/2092103002/ all IME result methods are
being routed to the right RenderWidget. Similarly, when an IME session is closed
on the browser side due to a click or tap, the right widget should be notifed
by receiving an IME confirm composition with empty text. Currently, this IPC is
sent to the tab's RenderWidget regardless of what the active widget is.

This CL will route the IPC to the right widget and adds a unit test for this
purpose.

BUG=578168, 602723

Committed: https://crrev.com/bbf1ae258c9f56929493ba5bfeca274a506b08b1
Cr-Commit-Position: refs/heads/master@{#403273}
==========