Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2116583004: Automated Autofill testing library + extension (Closed)

Created:
4 years, 5 months ago by asredzki
Modified:
4 years, 4 months ago
Reviewers:
Mathieu, sebsg
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, extensions-reviews_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Automated Autofill testing library + extension Adds a new browser automation testing library for Autofill. The library leverages ChromeDriver to playback tasks composed of user actions. A action recorder extension is included in order to assist in the process of creating test tasks. BUG= Committed: https://crrev.com/a3eb53ab137e94929787e026397fd12960cd15e3 Cr-Commit-Position: refs/heads/master@{#407283}

Patch Set 1 #

Total comments: 8

Patch Set 2 : Automated Autofill testing library + extension #

Patch Set 3 : Fixed indentation #

Total comments: 9

Patch Set 4 : Addressed nits, reduced preferences #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4287 lines, --5 lines) Patch
A + components/test/data/autofill/automated_integration/__init__.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A components/test/data/autofill/automated_integration/action_recorder_extension/README.md View 1 1 chunk +26 lines, -0 lines 0 comments Download
A components/test/data/autofill/automated_integration/action_recorder_extension/background/action_recorder.js View 1 1 chunk +460 lines, -0 lines 0 comments Download
A components/test/data/autofill/automated_integration/action_recorder_extension/background/action_set.js View 1 1 chunk +238 lines, -0 lines 0 comments Download
A components/test/data/autofill/automated_integration/action_recorder_extension/background/actions.js View 1 1 chunk +255 lines, -0 lines 0 comments Download
A components/test/data/autofill/automated_integration/action_recorder_extension/background/field_types.js View 1 1 chunk +81 lines, -0 lines 0 comments Download
A components/test/data/autofill/automated_integration/action_recorder_extension/background/indented_string_factory.js View 1 1 chunk +60 lines, -0 lines 0 comments Download
A components/test/data/autofill/automated_integration/action_recorder_extension/background/sites_to_visit.js View 1 1 chunk +10 lines, -0 lines 0 comments Download
A components/test/data/autofill/automated_integration/action_recorder_extension/content/action_handler.js View 1 1 chunk +454 lines, -0 lines 0 comments Download
A components/test/data/autofill/automated_integration/action_recorder_extension/content/x_path_tools.js View 1 2 3 1 chunk +353 lines, -0 lines 0 comments Download
A components/test/data/autofill/automated_integration/action_recorder_extension/icons/icon_idle.svg View 1 1 chunk +338 lines, -0 lines 0 comments Download
A components/test/data/autofill/automated_integration/action_recorder_extension/icons/icon_idle128.png View 1 Binary file 0 comments Download
A components/test/data/autofill/automated_integration/action_recorder_extension/icons/icon_idle16.png View 1 Binary file 0 comments Download
A components/test/data/autofill/automated_integration/action_recorder_extension/icons/icon_idle32.png View 1 Binary file 0 comments Download
A components/test/data/autofill/automated_integration/action_recorder_extension/icons/icon_idle48.png View 1 Binary file 0 comments Download
A components/test/data/autofill/automated_integration/action_recorder_extension/icons/icon_recording.svg View 1 1 chunk +338 lines, -0 lines 0 comments Download
A components/test/data/autofill/automated_integration/action_recorder_extension/icons/icon_recording128.png View 1 Binary file 0 comments Download
A components/test/data/autofill/automated_integration/action_recorder_extension/icons/icon_recording16.png View 1 Binary file 0 comments Download
A components/test/data/autofill/automated_integration/action_recorder_extension/icons/icon_recording32.png View 1 Binary file 0 comments Download
A components/test/data/autofill/automated_integration/action_recorder_extension/manifest.json View 1 1 chunk +49 lines, -0 lines 0 comments Download
A components/test/data/autofill/automated_integration/action_recorder_extension/popup/popup.html View 1 1 chunk +41 lines, -0 lines 0 comments Download
A components/test/data/autofill/automated_integration/action_recorder_extension/popup/popup.js View 1 1 chunk +136 lines, -0 lines 0 comments Download
A + components/test/data/autofill/automated_integration/autofill_task/__init__.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A components/test/data/autofill/automated_integration/autofill_task/actions.py View 1 2 3 1 chunk +405 lines, -0 lines 0 comments Download
A components/test/data/autofill/automated_integration/autofill_task/autofill_task.py View 1 2 3 1 chunk +89 lines, -0 lines 0 comments Download
A components/test/data/autofill/automated_integration/autofill_task/exceptions.py View 1 1 chunk +10 lines, -0 lines 0 comments Download
A components/test/data/autofill/automated_integration/autofill_task/generator.py View 1 2 3 1 chunk +40 lines, -0 lines 0 comments Download
A components/test/data/autofill/automated_integration/autofill_task/soft_task.py View 1 1 chunk +182 lines, -0 lines 0 comments Download
A + components/test/data/autofill/automated_integration/autofill_test/__init__.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A components/test/data/autofill/automated_integration/autofill_test/case.py View 1 1 chunk +47 lines, -0 lines 0 comments Download
A components/test/data/autofill/automated_integration/autofill_test/flow.py View 1 1 chunk +58 lines, -0 lines 0 comments Download
A components/test/data/autofill/automated_integration/autofill_test/runner.py View 1 1 chunk +44 lines, -0 lines 0 comments Download
A components/test/data/autofill/automated_integration/autofill_test/suite.py View 1 1 chunk +90 lines, -0 lines 0 comments Download
A components/test/data/autofill/automated_integration/main.py View 1 1 chunk +85 lines, -0 lines 0 comments Download
A components/test/data/autofill/automated_integration/task_flow.py View 1 1 chunk +197 lines, -0 lines 0 comments Download
A + components/test/data/autofill/automated_integration/tasks/__init__.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A components/test/data/autofill/automated_integration/tasks/sites.py View 1 2 1 chunk +128 lines, -0 lines 0 comments Download
A components/test/data/autofill/automated_integration/testdata/Default/Preferences View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A + components/test/data/autofill/automated_integration/testdata/Default/Web Data View 1 Binary file 0 comments Download
A components/test/data/autofill/automated_integration/testdata/README View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + components/test/data/autofill/automated_integration/testdata/__init__.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A components/test/data/autofill/automated_integration/testdata/profile_data.py View 1 1 chunk +75 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
asredzki
This isn't quite ready for merge, as more docs are needed and licenses have to ...
4 years, 5 months ago (2016-07-01 00:56:09 UTC) #2
sebsg
First set of comments for the first few js files. Will do another round in ...
4 years, 5 months ago (2016-07-04 09:02:38 UTC) #3
sebsg
Another quick comment. I notice that you use two verb tenses in the method comments ...
4 years, 5 months ago (2016-07-04 10:11:43 UTC) #4
asredzki
The testing library and extension are now clean, stable, and ready for final review. Previous ...
4 years, 5 months ago (2016-07-21 15:15:02 UTC) #6
sebsg
https://codereview.chromium.org/2116583004/diff/60001/components/test/data/autofill/automated_integration/autofill_task/actions.py File components/test/data/autofill/automated_integration/autofill_task/actions.py (right): https://codereview.chromium.org/2116583004/diff/60001/components/test/data/autofill/automated_integration/autofill_task/actions.py#newcode13 components/test/data/autofill/automated_integration/autofill_task/actions.py:13: from selenium.webdriver.common.action_chains import ActionChains Can you order these in ...
4 years, 5 months ago (2016-07-21 19:41:42 UTC) #8
asredzki
Comments have been addressed
4 years, 5 months ago (2016-07-21 20:02:13 UTC) #9
sebsg
lgtm let's commit this!
4 years, 5 months ago (2016-07-22 20:02:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2116583004/80001
4 years, 5 months ago (2016-07-22 20:03:45 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/109263)
4 years, 5 months ago (2016-07-22 21:16:35 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2116583004/80001
4 years, 5 months ago (2016-07-22 21:20:57 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 5 months ago (2016-07-22 22:39:10 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 22:41:21 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a3eb53ab137e94929787e026397fd12960cd15e3
Cr-Commit-Position: refs/heads/master@{#407283}

Powered by Google App Engine
This is Rietveld 408576698