chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java - Issue 2116583002: Credit card editor for PaymentRequest UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java

Issue 2116583002: Credit card editor for PaymentRequest UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address first round of comments from dfalcantara@. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java

index a5fb8fa3fc56e71ac92b19cbb4a0a12f466967c6..5fa0caf7d277d4b97527daeedf6798dd7b5d3be3 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java

@@ -84,7 +84,7 @@ public class ContactEditor extends EditorBase<AutofillContact> {

? new AutofillContact(new AutofillProfile(), null, null, false) : toEdit;

final EditorFieldModel phoneField = mRequestPayerPhone

- ? new EditorFieldModel(EditorFieldModel.INPUT_TYPE_HINT_PHONE,

+ ? EditorFieldModel.createTextInput(EditorFieldModel.INPUT_TYPE_HINT_PHONE,

mContext.getString(R.string.autofill_profile_editor_phone_number),

mPhoneNumbers, getPhoneValidator(),

mContext.getString(R.string.payments_phone_required_validation_message),

@@ -93,7 +93,7 @@ public class ContactEditor extends EditorBase<AutofillContact> {

: null;

final EditorFieldModel emailField = mRequestPayerEmail

- ? new EditorFieldModel(EditorFieldModel.INPUT_TYPE_HINT_EMAIL,

+ ? EditorFieldModel.createTextInput(EditorFieldModel.INPUT_TYPE_HINT_EMAIL,

mContext.getString(R.string.autofill_profile_editor_email_address),

mEmailAddresses, getEmailValidator(),

mContext.getString(R.string.payments_email_required_validation_message),

@@ -130,8 +130,8 @@ public class ContactEditor extends EditorBase<AutofillContact> {

contact.getProfile().setEmailAddress(email);

}

- PersonalDataManager.getInstance().setProfile(contact.getProfile());

- contact.completeContact(phone, email);

+ String guid = PersonalDataManager.getInstance().setProfile(contact.getProfile());

+ contact.completeContact(guid, phone, email);

callback.onResult(contact);

}

});