chrome/android/java/res/layout/payment_request_editor_dropdown.xml - Issue 2116583002: Credit card editor for PaymentRequest UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/payment_request_editor_dropdown.xml

Issue 2116583002: Credit card editor for PaymentRequest UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address first round of comments from dfalcantara@. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/android/java/res/layout/payment_request_editor_dropdown.xml

diff --git a/chrome/android/java/res/layout/payment_request_editor_dropdown.xml b/chrome/android/java/res/layout/payment_request_editor_dropdown.xml

index df10eb7af4d9c5d84c02bf6621db3c6a9e10788c..ab8cacb3a0d5b49569c3b0e6027d9ef6954b94ab 100644

--- a/chrome/android/java/res/layout/payment_request_editor_dropdown.xml

+++ b/chrome/android/java/res/layout/payment_request_editor_dropdown.xml

@@ -7,10 +7,10 @@

xmlns:android="http://schemas.android.com/apk/res/android"

android:layout_width="match_parent"

android:layout_height="wrap_content"

- android:orientation="vertical"

- android:paddingBottom="@dimen/pref_autofill_content_spacing"

- android:paddingStart="@dimen/pref_autofill_field_horizontal_padding"

- android:paddingEnd="@dimen/pref_autofill_field_horizontal_padding">

+ android:layout_marginBottom="@dimen/pref_autofill_content_spacing"

+ android:layout_marginStart="@dimen/pref_autofill_field_horizontal_padding"

+ android:layout_marginEnd="@dimen/pref_autofill_field_horizontal_padding"

+ android:orientation="vertical">

<TextView

android:id="@+id/spinner_label"

@@ -25,5 +25,4 @@

android:layout_marginTop="@dimen/pref_autofill_field_top_margin" />

gone 2016/07/14 22:36:36 Put the newline back; keeps it symmetric with the

please use gerrit instead 2016/07/15 00:24:37 Done.

</LinearLayout>