Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2116573002: Release MediaCodec on another thread more often. (Closed)

Created:
4 years, 5 months ago by liberato (no reviews please)
Modified:
4 years, 5 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Release MediaCodec on another thread more often. Since MediaCodec::release() can hang, this CL moves more cases of it to a separate thread when needed. Previously, we did this only during AVDA destruction. This CL adds support for other cases in which we replace or clear |media_codec_|. BUG=613238 Committed: https://crrev.com/6dbf26869f5f64e618e31b314d0476d930fb55eb Cr-Commit-Position: refs/heads/master@{#403345}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -17 lines) Patch
M media/gpu/android_video_decode_accelerator.h View 1 chunk +6 lines, -0 lines 0 comments Download
M media/gpu/android_video_decode_accelerator.cc View 6 chunks +28 lines, -17 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
liberato (no reviews please)
4 years, 5 months ago (2016-06-30 18:10:48 UTC) #3
DaleCurtis
lgtm
4 years, 5 months ago (2016-06-30 18:11:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2116573002/1
4 years, 5 months ago (2016-06-30 18:13:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/29614)
4 years, 5 months ago (2016-06-30 18:17:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2116573002/1
4 years, 5 months ago (2016-06-30 18:21:30 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/255714)
4 years, 5 months ago (2016-06-30 20:43:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2116573002/1
4 years, 5 months ago (2016-06-30 22:17:47 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 23:43:14 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 23:45:10 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6dbf26869f5f64e618e31b314d0476d930fb55eb
Cr-Commit-Position: refs/heads/master@{#403345}

Powered by Google App Engine
This is Rietveld 408576698