third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h - Issue 2116563003: [DevTools] Report unhandled exceptions and promise rejections through Runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h

Issue 2116563003: [DevTools] Report unhandled exceptions and promise rejections through Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tests pass Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp ('K') | « third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp » ('j') | third_party/WebKit/Source/platform/v8_inspector/js_protocol.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h

index e4da4367551c4a0e79fa3c6e35c975d2fab7d9b5..a88770641b23593d126239efdc940dca289deacd 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h

@@ -132,7 +132,8 @@ public:

void idleFinished() override;

bool addConsoleMessage(int contextGroupId, MessageSource, MessageLevel, const String16& message, const String16& url, unsigned lineNumber, unsigned columnNumber, std::unique_ptr<V8StackTrace>, int scriptId, const String16& requestIdentifier) override;

void logToConsole(v8::Local<v8::Context>, const String16& message, v8::Local<v8::Value> arg1, v8::Local<v8::Value> arg2) override;

- unsigned promiseRejected(v8::Local<v8::Context>, const String16& errorMessage, v8::Local<v8::Value> reason, const String16& url, unsigned lineNumber, unsigned columnNumber, std::unique_ptr<V8StackTrace>, int scriptId) override;

+ void exceptionUnhandled(int contextGroupId, const String16& errorMessage, const String16& url, unsigned lineNumber, unsigned columnNumber, std::unique_ptr<V8StackTrace>, int scriptId) override;

+ unsigned promiseRejected(v8::Local<v8::Context>, const String16& errorMessage, v8::Local<v8::Value> exception, const String16& url, unsigned lineNumber, unsigned columnNumber, std::unique_ptr<V8StackTrace>, int scriptId) override;

void promiseRejectionRevoked(v8::Local<v8::Context>, unsigned promiseRejectionId) override;

void consoleMessagesCount(int contextGroupId, unsigned* total, unsigned* withArguments) override;

std::unique_ptr<V8StackTrace> createStackTrace(v8::Local<v8::StackTrace>) override;

@@ -186,7 +187,7 @@ private:

ConsoleStorageMap m_consoleStorageMap;

int m_capturingStackTracesCount;

int m_muteConsoleCount;

- unsigned m_lastConsoleMessageId;

+ unsigned m_lastExceptionId;

int m_enabledAgentsCount;

bool m_breakpointsActivated;

v8::Global<v8::Object> m_debuggerScript;