Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 2116563002: Fix assert and re-enable tests for PaymentRequest. (Closed)

Created:
4 years, 5 months ago by please use gerrit instead
Modified:
4 years, 5 months ago
Reviewers:
gone, horo
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix assert and re-enable tests for PaymentRequest. BUG=624653 Committed: https://crrev.com/a474a14a78932c7551fabf03981bbe4427f7c1b2 Cr-Commit-Position: refs/heads/master@{#403217}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteContactDetailsTest.java View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
please use gerrit instead
dfalcantara@, ptal. horo@, fyi.
4 years, 5 months ago (2016-06-30 17:08:51 UTC) #2
gone
lgtm
4 years, 5 months ago (2016-06-30 17:27:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2116563002/1
4 years, 5 months ago (2016-06-30 17:47:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 17:53:21 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 17:53:29 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 17:55:45 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a474a14a78932c7551fabf03981bbe4427f7c1b2
Cr-Commit-Position: refs/heads/master@{#403217}

Powered by Google App Engine
This is Rietveld 408576698