Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 2116543002: Cleanup PLSPathBatch (Closed)

Created:
4 years, 5 months ago by bsalomon
Modified:
4 years, 5 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@moreninepatch
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : round out #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -144 lines) Patch
M src/gpu/batches/GrPLSPathRenderer.cpp View 1 5 chunks +107 lines, -144 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2116543002/1
4 years, 5 months ago (2016-06-30 15:04:41 UTC) #3
bsalomon
4 years, 5 months ago (2016-06-30 15:05:38 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-30 15:55:24 UTC) #7
robertphillips
lgtm https://codereview.chromium.org/2116543002/diff/1/src/gpu/batches/GrPLSPathRenderer.cpp File src/gpu/batches/GrPLSPathRenderer.cpp (right): https://codereview.chromium.org/2116543002/diff/1/src/gpu/batches/GrPLSPathRenderer.cpp#newcode836 src/gpu/batches/GrPLSPathRenderer.cpp:836: GrResourceProvider* rp = target->resourceProvider(); SkRect bounds; this->bounds()->roundOut(&bounds); ?
4 years, 5 months ago (2016-06-30 16:58:28 UTC) #8
bsalomon
https://codereview.chromium.org/2116543002/diff/1/src/gpu/batches/GrPLSPathRenderer.cpp File src/gpu/batches/GrPLSPathRenderer.cpp (right): https://codereview.chromium.org/2116543002/diff/1/src/gpu/batches/GrPLSPathRenderer.cpp#newcode836 src/gpu/batches/GrPLSPathRenderer.cpp:836: GrResourceProvider* rp = target->resourceProvider(); On 2016/06/30 16:58:27, robertphillips wrote: ...
4 years, 5 months ago (2016-06-30 17:33:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2116543002/20001
4 years, 5 months ago (2016-07-01 03:28:14 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 03:45:42 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/065c8cff8ff27e75846f6b53e74ae1f12171a86f

Powered by Google App Engine
This is Rietveld 408576698