Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 2116533004: [turbofan] Properly lower NumberSinh, NumberCosh and NumberTanh. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Properly lower NumberSinh, NumberCosh and NumberTanh. R=jarin@chromium.org BUG=chromium:625121 Committed: https://crrev.com/9c281f2407fe8b7d366f4767a8737de04dee17ba Cr-Commit-Position: refs/heads/master@{#37479}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M src/compiler/simplified-lowering.cc View 2 chunks +4 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-625121.js View 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
4 years, 5 months ago (2016-07-01 12:25:30 UTC) #1
Jarin
lgtm
4 years, 5 months ago (2016-07-01 12:28:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2116533004/1
4 years, 5 months ago (2016-07-01 12:28:35 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-01 12:50:51 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 12:53:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c281f2407fe8b7d366f4767a8737de04dee17ba
Cr-Commit-Position: refs/heads/master@{#37479}

Powered by Google App Engine
This is Rietveld 408576698