[ic] [stubs] Add missing GetExtraICState method to CompareICStub.

[ic] [stubs] Add missing GetExtraICState method to CompareICStub.

Added missing GetExtraICState() function for CompareICStub. Without it,
code->extra_ic_state() in IC::StateFromCode was returning zero, which was
causing some performance regressions, as the TypeFeedbackInfo was not updated
correctly, resulting in the runtime profiler choosing not to optimise some
functions that we previously would.

BUG=

Committed: https://crrev.com/c88cc5b1995fc4872abfd5e9f02365a69c3a8b6b
Cr-Commit-Position: refs/heads/master@{#37457}

[georgia.kouveli, 2016-06-30 14:18:01]

georgia.kouveli@arm.com changed reviewers:
+ ishell@chromium.org, verwaest@chromium.org

[Igor Sheludko, 2016-06-30 15:29:37]

https://codereview.chromium.org/2116523002/diff/1/src/code-stubs.h
File src/code-stubs.h (left):

https://codereview.chromium.org/2116523002/diff/1/src/code-stubs.h#oldcode1973
src/code-stubs.h:1973: }
Nice catch! Thank you!
However, I think the right fix would be to add this method here instead (like in
some other stubs):

  ExtraICState GetExtraICState() const final {
    return static_cast<ExtraICState>(minor_key_);
  }

[georgia.kouveli, 2016-06-30 16:23:04]

Description was changed from

==========
[ic] Fix IC::StateFromCode for COMPARE_ICs.

The function (introduced at 9dc62d2721) was using code->extra_ic_state() to
initialize a CompareICStub in order to get the InlineCacheState, however that
field is zero at the time when IC::StateFromCode is called. Use
code->stub_key() instead.

This was causing some performance regressions, as the TypeFeedbackInfo was not
updated as before 9dc62d2721, resulting in the runtime profiler choosing not to
optimise some functions that we previously would.

BUG=
==========

to

==========
[ic] [stubs] Add missing GetExtraICState method to CompareICStub.

Added missing GetExtraICState() function for CompareICStub. Without it,
code->extra_ic_state() in IC::StateFromCode was returning zero, which was
causing some performance regressions, as the TypeFeedbackInfo was not updated
correctly, resulting in the runtime profiler choosing not to optimise some
functions that we previously would.

BUG=
==========

[georgia.kouveli, 2016-06-30 16:25:38]

Updated. PTAL.

[Igor Sheludko, 2016-06-30 16:26:48]

LGTM. Thanks!

[georgia.kouveli, 2016-06-30 16:29:51]

The CQ bit was checked by georgia.kouveli@arm.com

[commit-bot: I haz the power, 2016-06-30 16:30:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 16:58:14]

Description was changed from

==========
[ic] [stubs] Add missing GetExtraICState method to CompareICStub.

Added missing GetExtraICState() function for CompareICStub. Without it,
code->extra_ic_state() in IC::StateFromCode was returning zero, which was
causing some performance regressions, as the TypeFeedbackInfo was not updated
correctly, resulting in the runtime profiler choosing not to optimise some
functions that we previously would.

BUG=
==========

to

==========
[ic] [stubs] Add missing GetExtraICState method to CompareICStub.

Added missing GetExtraICState() function for CompareICStub. Without it,
code->extra_ic_state() in IC::StateFromCode was returning zero, which was
causing some performance regressions, as the TypeFeedbackInfo was not updated
correctly, resulting in the runtime profiler choosing not to optimise some
functions that we previously would.

BUG=
==========

[commit-bot: I haz the power, 2016-06-30 16:58:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-30 17:01:17]

Description was changed from

==========
[ic] [stubs] Add missing GetExtraICState method to CompareICStub.

Added missing GetExtraICState() function for CompareICStub. Without it,
code->extra_ic_state() in IC::StateFromCode was returning zero, which was
causing some performance regressions, as the TypeFeedbackInfo was not updated
correctly, resulting in the runtime profiler choosing not to optimise some
functions that we previously would.

BUG=
==========

to

==========
[ic] [stubs] Add missing GetExtraICState method to CompareICStub.

Added missing GetExtraICState() function for CompareICStub. Without it,
code->extra_ic_state() in IC::StateFromCode was returning zero, which was
causing some performance regressions, as the TypeFeedbackInfo was not updated
correctly, resulting in the runtime profiler choosing not to optimise some
functions that we previously would.

BUG=

Committed: https://crrev.com/c88cc5b1995fc4872abfd5e9f02365a69c3a8b6b
Cr-Commit-Position: refs/heads/master@{#37457}
==========

[commit-bot: I haz the power, 2016-06-30 17:01:18]

Patchset 2 (id:??) landed as
https://crrev.com/c88cc5b1995fc4872abfd5e9f02365a69c3a8b6b
Cr-Commit-Position: refs/heads/master@{#37457}