Make Foreign Fetch an origin trial.

third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 18 matching lines @@
  */
 
 #include "bindings/core/v8/V8Binding.h"
 
 #include "bindings/core/v8/ScriptController.h"
 #include "bindings/core/v8/V8AbstractEventListener.h"
 #include "bindings/core/v8/V8ArrayBufferView.h"
 #include "bindings/core/v8/V8BindingMacros.h"
 #include "bindings/core/v8/V8Element.h"
 #include "bindings/core/v8/V8EventTarget.h"
+#include "bindings/core/v8/V8HTMLLinkElement.h"
 #include "bindings/core/v8/V8NodeFilter.h"
 #include "bindings/core/v8/V8NodeFilterCondition.h"
 #include "bindings/core/v8/V8ObjectConstructor.h"
 #include "bindings/core/v8/V8Window.h"
 #include "bindings/core/v8/V8WorkerGlobalScope.h"
 #include "bindings/core/v8/V8WorkletGlobalScope.h"
 #include "bindings/core/v8/V8XPathNSResolver.h"
 #include "bindings/core/v8/WindowProxy.h"
 #include "bindings/core/v8/WorkerOrWorkletScriptController.h"
 #include "bindings/core/v8/custom/V8CustomXPathNSResolver.h"
@@ skipping 753 matching lines @@
     ASSERT(frame);
     return frame->windowProxy(world)->contextIfInitialized();
 }
 
 void installOriginTrialsCore(ScriptState* scriptState)
 {
     // TODO(iclelland): Generate all of this logic at compile-time, based on the
     // configuration of origin trial enabled attibutes and interfaces in IDL
     // files. (crbug.com/615060)
 
-    // Initialization code for origin trials for core bindings, if necessary,
-    // should go here.
+    v8::Local<v8::Context> context = scriptState->context();
+    ExecutionContext* executionContext = toExecutionContext(context);
+    OriginTrialContext* originTrialContext = OriginTrialContext::from(executionContext, OriginTrialContext::DontCreateIfNotExists);
+    if (!originTrialContext)
+        return;
+
+    if (!originTrialContext->featureBindingsInstalled("LinkServiceWorker") && (RuntimeEnabledFeatures::linkServiceWorkerEnabled() || originTrialContext->isFeatureEnabled("ForeignFetch"))) {

[iclelland, 2016/07/26 20:32:06]

I thing you could replace this with

    if (!originTrialContext->featureBindingsInstalled("ForeignFetch") &&
(RuntimeEnabledFeatures::linkServiceWorkerEnabled() ||
originTrialContext->isFeatureEnabled("ForeignFetch")))

and then remove the lines that set FeatureBindingsInstalled("LinkServiceWorker")
below. This all still needs to be generated code, but the intention is that the
FeatureBindingsInstalled set has keys that are tied to the origin trial feature
names, since each origin trial should only be installed once per context.

+        if (executionContext->isDocument()) {
+            V8HTMLLinkElement::installLinkServiceWorker(scriptState);
+        }
+    }
 }
 
 namespace {
 InstallOriginTrialsFunction s_installOriginTrialsFunction = &installOriginTrialsCore;
 }
 
 void installOriginTrials(ScriptState* scriptState)
 {
     v8::Local<v8::Context> context = scriptState->context();
     ExecutionContext* executionContext = toExecutionContext(context);
     OriginTrialContext* originTrialContext = OriginTrialContext::from(executionContext, OriginTrialContext::DontCreateIfNotExists);
     if (!originTrialContext)
         return;
 
     ScriptState::Scope scope(scriptState);
 
     (*s_installOriginTrialsFunction)(scriptState);
 
     // Mark each enabled feature as having been installed.
     if (!originTrialContext->featureBindingsInstalled("DurableStorage") && (RuntimeEnabledFeatures::durableStorageEnabled() || originTrialContext->isFeatureEnabled("DurableStorage"))) {
         originTrialContext->setFeatureBindingsInstalled("DurableStorage");
     }
 
     if (!originTrialContext->featureBindingsInstalled("WebBluetooth") && (RuntimeEnabledFeatures::webBluetoothEnabled() || originTrialContext->isFeatureEnabled("WebBluetooth"))) {
         originTrialContext->setFeatureBindingsInstalled("WebBluetooth");
     }
+
+    if (!originTrialContext->featureBindingsInstalled("LinkServiceWorker") && (RuntimeEnabledFeatures::webBluetoothEnabled() || originTrialContext->isFeatureEnabled("ForeignFetch"))) {
+        originTrialContext->setFeatureBindingsInstalled("LinkServiceWorker");
+    }
+
+    if (!originTrialContext->featureBindingsInstalled("ForeignFetch") && (RuntimeEnabledFeatures::webBluetoothEnabled() || originTrialContext->isFeatureEnabled("ForeignFetch"))) {
+        originTrialContext->setFeatureBindingsInstalled("ForeignFetch");
+    }
 }
 
 InstallOriginTrialsFunction setInstallOriginTrialsFunction(InstallOriginTrialsFunction newInstallOriginTrialsFunction)
 {
     InstallOriginTrialsFunction originalFunction = s_installOriginTrialsFunction;
     s_installOriginTrialsFunction = newInstallOriginTrialsFunction;
     return originalFunction;
 }
 
 void crashIfIsolateIsDead(v8::Isolate* isolate)
@@ skipping 98 matching lines @@
     v8SetReturnValue(info, perContextData->constructorForType(WrapperTypeInfo::unwrap(data)));
 }
 
 v8::Local<v8::Value> freezeV8Object(v8::Local<v8::Value> value, v8::Isolate* isolate)
 {
     v8CallOrCrash(value.As<v8::Object>()->SetIntegrityLevel(isolate->GetCurrentContext(), v8::IntegrityLevel::kFrozen));
     return value;
 }
 
 } // namespace blink