Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1472)

Unified Diff: third_party/WebKit/WebCore/rendering/RenderSVGGradientStop.h

Issue 21165: Revert the merge. Mac build is mysteriously broken. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/WebCore/rendering/RenderSVGGradientStop.h
===================================================================
--- third_party/WebKit/WebCore/rendering/RenderSVGGradientStop.h (revision 9383)
+++ third_party/WebKit/WebCore/rendering/RenderSVGGradientStop.h (working copy)
@@ -41,10 +41,11 @@
virtual void layout();
- // This override is needed to prevent an assert on <svg><stop /></svg>
- // RenderObject's default impl asserts.
+ // This override is needed to prevent crashing on <svg><stop /></svg>
+ // RenderObject's default impl asks the parent Object and RenderSVGRoot
+ // asks all child RenderObjects for overflow rects, thus infinite loop.
// https://bugs.webkit.org/show_bug.cgi?id=20400
- virtual IntRect clippedOverflowRectForRepaint(RenderBoxModelObject*) { return IntRect(); }
+ virtual IntRect clippedOverflowRectForRepaint(RenderBox*) { return IntRect(); }
protected:
virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle);

Powered by Google App Engine
This is Rietveld 408576698