Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1213)

Unified Diff: third_party/WebKit/WebCore/bindings/scripts/CodeGenerator.pm

Issue 21165: Revert the merge. Mac build is mysteriously broken. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/WebCore/bindings/scripts/CodeGenerator.pm
===================================================================
--- third_party/WebKit/WebCore/bindings/scripts/CodeGenerator.pm (revision 9383)
+++ third_party/WebKit/WebCore/bindings/scripts/CodeGenerator.pm (working copy)
@@ -131,6 +131,9 @@
my $functionsRef = $dataNode->functions;
my $attributesRef = $dataNode->attributes;
+ # Exception: For the DOM 'Node' is our topmost baseclass, not EventTargetNode.
+ return if $parentsMax eq 1 and $parents[0] eq "EventTargetNode";
+
foreach (@{$dataNode->parents}) {
if ($ignoreParent) {
# Ignore first parent class, already handled by the generation itself.
@@ -193,6 +196,9 @@
foreach (@{$dataNode->parents}) {
my $interface = $object->StripModule($_);
+ if ($interface eq "EventTargetNode") {
+ $interface = "Node";
+ }
# Step #1: Find the IDL file associated with 'interface'
$endCondition = 0;

Powered by Google App Engine
This is Rietveld 408576698