Issue 2116483002: Handle constant ?? expressions in constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2116483002: Handle constant ?? expressions in constructors. (Closed)

Created:
4 years, 5 months ago by Johnni Winther

Modified:
4 years, 5 months ago

Reviewers:
Harry Terkelsen

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -2 lines)			Patch
M	pkg/compiler/lib/src/constants/constant_constructors.dart	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/dart2js.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/compiler/lib/src/serialization/element_serialization.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/compiler/dart2js/constant_expression_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/compiler/dart2js/serialization/test_data.dart	View	1 chunk	+17 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Johnni Winther

4 years, 5 months ago (2016-07-01 09:04:22 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5e3419a8e2f4719e5aec1021006490cd7d2e1f84 (presubmit successful).